Re: [Bodington-developers] i18n res updated

[Matthew B. <mat...@co...>]

Alistair Young wrote:
> nice one! that'll do. My only concern was it caused NPE with style_0/ 
> recycler/main.html.

Was that a NPE at compile or runtime?

 > That's nothing to do with the template  compilation
> problem. It's a nice enhancement for dynamic localisation  though. 
> Before you commit, can you make sure you're not seeing any  NPE with non 
> localised templates?

Ok. I'll also remove your for localisation from getCharacterData(). One 
thing to note is I change the syntax for localised facility calls from:

<call>
   <target method="variable"><variable name="facility"/></target>
   <parameters>
     <variable name="request"/>
     <variable name="writer"/>
     <literal type="String">
       <localise id="page.title.text"/>
     </literal>
   </parameters>
</call>

to:

<call>
   <target method="variable"><variable name="facility"/></target>
   <parameters>
     <variable name="request"/>
     <variable name="writer"/>
     <localise id="page.title.text"/>
   </parameters>
</call>

But my orginal patch include fixing the templates that were affected.

-- 
+--Matthew Buckett-----------------------------------------+
| VLE Developer, Learning Technologies Group               |
| Tel: +44 (0) 1865 283660 http://www.oucs.ox.ac.uk/       |
+------------Computing Services, University of Oxford------+