Re: [Bodington-developers] Handling Errors from BuildingSession (and children) sensibly

[Matthew B. <mat...@co...>]

Antony Corfield wrote:

 > Good idea, user exceptions should
> contain user-friendly message and could be used to report back to user  
> (could still be logged at a finer level). Can't see that "You don't  
> have access rights allowing you to delete sections here." is output to  
> user in LogBookFacility!?

Here:

>> +++ src/org/bodington/logbook/servlet/LogBookFacility.java    21 Jun 
>> 2005  15:55:31 -0000
>> @@ -66,6 +66,7 @@
>>  import org.bodington.logbook.server.*;
>>  import org.bodington.database.PrimaryKey;
>>  import org.bodington.server.BuildingContext;
>> +import org.bodington.server.BuildingServerUserException;
>>  import org.bodington.server.BuildingSession;
>>  import org.bodington.server.BuildingSessionManagerImpl;
>>  import org.bodington.server.BuildingServerException;
>> @@ -1554,6 +1555,11 @@
>>              {
>>              lb_session.deleteSection( section_id );
>>              }
>> +        catch (BuildingServerUserException bsue)
>> +            {
>> +            out.write(bsue.getMessage());
>> +            return;
>> +            }
>>          catch ( BuildingServerException bsex )
>>              {
>>              logException( out, "LogBookFacility", "deleteSection",


> ps. after your Skye visit, can we now refer to you as (Matthew) The  Bucket! 

After my close inspection I must say you have very nice toilets 
installed in your student halls ;-)

-- 
+--Matthew Buckett-----------------------------------------+
| VLE Developer, Learning Technologies Group               |
| Tel: +44 (0) 1865 283660 http://www.oucs.ox.ac.uk/       |
+------------Computing Services, University of Oxford------+