From: Matthew B. <mat...@co...> - 2005-05-25 12:30:44
|
I have had a quick hack at removing the system property bodington.home that is used by Bodington. The problem with using a System property is that if you have two copies of Bodington running in the same Servlet container they will share the value (bad). The bodington.home property was almost exclusively used to load the DTDs. So I have moved the DTDs into the classpath and hacked up a new EntityResolver that looks in the classpath by default. This means that things like template compilation don't need to have properties set to work. The correct way to solve this would have been to use a CatalogResolver (http://xml.apache.org/commons/components/resolver/) which I might sort out at some point down the road. Attached is my current patch for WebLearn HEAD at fixing this. I'll push it across to Bodington HEAD unless anyone has any objections. NB: As a side note it seems that Bodington doesn't use the DOCTYPE declaration correctly and confuses the PUBLIC and SYSTEM attributes (look at any of the templates). I'm guessing this was done because the XML parser doesn't assume the SYSTEM DTD relative and so passes it through untouched. -- +--Matthew Buckett-----------------------------------------+ | VLE Developer, Learning Technologies Group | | Tel: +44 (0) 1865 283660 http://www.oucs.ox.ac.uk/ | +------------Computing Services, University of Oxford------+ |