bodington-developers

[Bodington-developers] HTTP size header on downloaded files

[Matthew B. <mat...@ou...>]

We had reports of downloaded MP3s not playing correctly with quicktime 
under firefox. Looking into this it seemed that the Content-length was 
not being set on the downloaded file which mean that the quicktime 
plugin was only playing the first few seconds of the file.

The problem was that the compiler was converting the constant 0x80000000 
to Integer.MIN_VALUE on the line:

long size = uf.getSize();
if (size > 0L && size < 0x80000000)
   res.setContentLength((int) size);

which means that the header was never being set.

I've converted this to:

if (size > 0L && size <= (long)Integer.MAX_VALUE)

which means content length headers should get set for most uploaded 
files. The fix is in Bodington CVS HEAD.

-- 
  -- Matthew Buckett, VLE Developer
  -- Learning Technologies Group, Oxford University Computing Services
  -- Tel: +44 (0)1865 283660 http://www.oucs.ox.ac.uk/ltg/

Re: [Bodington-developers] HTTP size header on downloaded files

[Alexis O'C. <ale...@ou...>]

Matthew Buckett wrote:
> We had reports of downloaded MP3s not playing correctly with quicktime 
> under firefox. Looking into this it seemed that the Content-length was 
> not being set on the downloaded file which mean that the quicktime 
> plugin was only playing the first few seconds of the file.
>
> The problem was that the compiler was converting the constant 0x80000000 
> to Integer.MIN_VALUE on the line:
>
> long size = uf.getSize();
> if (size > 0L && size < 0x80000000)
>    res.setContentLength((int) size);
>
>   
Good work. Nothing like a spot of gratuitous use of hexadecimal ;-).

Alexis

Re: [Bodington-developers] HTTP size header on downloaded files

[Antony C. <an...@sm...>]

Excellent Matthew, thanks for that fix!

On 23 Jan 2007, at 11:40, Matthew Buckett wrote:

> We had reports of downloaded MP3s not playing correctly with quicktime
> under firefox. Looking into this it seemed that the Content-length was
> not being set on the downloaded file which mean that the quicktime
> plugin was only playing the first few seconds of the file.
>
> The problem was that the compiler was converting the constant  
> 0x80000000
> to Integer.MIN_VALUE on the line:
>
> long size = uf.getSize();
> if (size > 0L && size < 0x80000000)
>    res.setContentLength((int) size);
>
> which means that the header was never being set.
>
> I've converted this to:
>
> if (size > 0L && size <= (long)Integer.MAX_VALUE)
>
> which means content length headers should get set for most uploaded
> files. The fix is in Bodington CVS HEAD.
>
> --  
>   -- Matthew Buckett, VLE Developer
>   -- Learning Technologies Group, Oxford University Computing Services
>   -- Tel: +44 (0)1865 283660 http://www.oucs.ox.ac.uk/ltg/
>
> ----------------------------------------------------------------------- 
> --
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to  
> share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php? 
> page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Bodington-developers mailing list
> Bod...@li...
> https://lists.sourceforge.net/lists/listinfo/bodington-developers