Thread: [Bodington-developers] JUnit

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

Hi

Would anyone have a problem IF I pushed the following onto bodington head?

Ta
Atif.

Atif Suleman wrote:
> Hi
> 
> Would anyone have a problem IF I pushed the following onto bodington head?

Yes unless you are going to commit some JUnit tests as well ;-)

What have you written tests for?

Attached is the current WebLearn build.xml and I think we had the tests
working almost identically. Also attached is BuildingServerTest which
allows you to do intergration tests on some of the higher level
Bodington code.

-- 
 -- Matthew Buckett, VLE Developer
 -- Learning Technologies Group, Oxford University Computing Services
 -- Tel: +44 (0)1865 283660 http://www.oucs.ox.ac.uk/ltg/

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
  <meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
  <title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
Matthew Buckett wrote:
<blockquote cite="mid...@ou..." type="cite">
  <pre wrap="">Atif Suleman wrote:
  </pre>
  <blockquote type="cite">
    <pre wrap="">Hi

Would anyone have a problem IF I pushed the following onto bodington head?
    </pre>
  </blockquote>
  <pre wrap=""><!---->
Yes unless you are going to commit some JUnit tests as well ;-)

What have you written tests for?</pre>
</blockquote>
The following at the moment: 
* GroupsMapperEngineTest.java 
* GroupsMapperPolicyTest.java 
 
<blockquote type="cite">
 <pre wrap="">Attached is the current WebLearn build.xml and I think we had the tests
working almost identically. Also attached is BuildingServerTest which
allows you to do intergration tests on some of the higher level
Bodington code.</pre>
</blockquote>
Cool. How about pushing your build.xml junit work onto bodington head
and also BuildingServerTest. 
 
 
Ta 
Atif. 
</body>
</html>

Atif Suleman wrote:
> Matthew Buckett wrote:
> 
>>Atif Suleman wrote:
>>  
>>
>>>Hi
>>>
>>>Would anyone have a problem IF I pushed the following onto bodington head?
>>>    
>>>
>>
>>Yes unless you are going to commit some JUnit tests as well ;-)
>>
>>What have you written tests for?
>>
> The following at the moment:
> * GroupsMapperEngineTest.java
> * GroupsMapperPolicyTest.java

Nice.

>>Attached is the current WebLearn build.xml and I think we had the tests
>>working almost identically. Also attached is BuildingServerTest which
>>allows you to do intergration tests on some of the higher level
>>Bodington code.
>>
> Cool. How about pushing your build.xml junit work onto bodington head
> and also BuildingServerTest.

I think your patch is better as it extracts the test classpath out. If
you commit it I'll probably muller it (add HSQLDB and test-init) a
little so that the BuildingServerTest works but otherwise looks good.

-- 
 -- Matthew Buckett, VLE Developer
 -- Learning Technologies Group, Oxford University Computing Services
 -- Tel: +44 (0)1865 283660 http://www.oucs.ox.ac.uk/ltg/

Matthew Buckett wrote:

>I think your patch is better as it extracts the test classpath out. If
>you commit it I'll probably muller it (add HSQLDB and test-init) a
>little so that the BuildingServerTest works but otherwise looks good.
>  
>
My patch is commit onto bodington head.  It would be cool if we had 
BuildingServerTest on head THEN any test that need to do higher level
Bodington code Test could subclass BuildingServerTest AND not worry 
about setting up and tearing down bodington database.

Ta
Atif.

Atif Suleman wrote:
> Matthew Buckett wrote:
> 
>> I think your patch is better as it extracts the test classpath out. If
>> you commit it I'll probably muller it (add HSQLDB and test-init) a
>> little so that the BuildingServerTest works but otherwise looks good.
>>  
>>
> My patch is commit onto bodington head.  It would be cool if we had
> BuildingServerTest on head THEN any test that need to do higher level
> Bodington code Test could subclass BuildingServerTest AND not worry
> about setting up and tearing down bodington database.

Will do, but BuildingServerTest is a bad solution:

- It's slow which doesn't encourage people to run the tests.
- It's complicated which means changing one thing at the database level
can break lots of tests.
- It isn't really a unit test but an intergration but there isn't a good
way of testing some parts of the Bodington code without creating 100s of
mock objects.

-- 
 -- Matthew Buckett, VLE Developer
 -- Learning Technologies Group, Oxford University Computing Services
 -- Tel: +44 (0)1865 283660 http://www.oucs.ox.ac.uk/ltg/

Matthew Buckett wrote:

>>Matthew Buckett wrote:
>>Will do, but BuildingServerTest is a bad solution:
>>
>>.................
>>- It isn't really a unit test but an intergration but there isn't a good
>>way of testing some parts of the Bodington code without creating 100s of
>>mock objects.
>>
>>    
>>
I agree.

Ta
Atif.

Thread: [Bodington-developers] JUnit

bodington-developers