From: tld <tl...@tl...> - 2002-06-01 18:39:03
|
Hello. While examining the CPU code I couldn't help noticing many useless instructions and bad coding practice. I'm expecially referring to the gotos and the returns, often used in constructs like this: some_function() { if (something) { ... return; } else { ... return; } } (see cpu/decode16.cc) or, ... if (something) { ... goto there; } else { ... goto there; } there: ... (see cpu/cpu.cc) well, d'oh! Is there any good reason they should be kept there, or I can start cleaning the code at once? Also, why the (sometimes) indented closing bracket? Thank you. TLD |