From: Kevin O'C. <ke...@ko...> - 2008-10-28 00:03:31
|
Hi Gleb, On Mon, Oct 27, 2008 at 02:01:12PM +0200, Gleb Natapov wrote: > On Mon, Oct 27, 2008 at 12:58:36PM +0200, Stanislav Shwartsman wrote: > > Could you explain a bit more about these patches ? > > > Suspend to ram (or "stand by" in windows) is a machine state when only > memory gets the power and all other devices including CPU are powered > down. The memory content is preserved and OS can resume almost > instantly. In order for BIOS to support S3 it shouldn't touch any memory > that is not listed as reserved in e820 map, otherwise it may overwrite > OS data and OS will crash after resume. I think we're better off detecting that the boot is an S3 resume and then avoid touching any memory in that case. I think trying to change the bios so that all boots don't touch any memory is going to be fragile. Also, the code looks like it is trying to run the option roms after an S3 resume. This doesn't seem right, as I think the option roms themselves could clobber memory. -Kevin |