[Boa Constr] Re: Big patch

[Riaan B. <riaan@e.co.za>]

Hi Shane,

Big thanks!

Shane Hathaway wrote:
> 
> Sorry this patch is so big, but I ended up doing three things:
> 
> 1) Changing all references to 'model.module' to 'model.getModule()' then
> setting it up so that the module is only loaded when the user needs it.
> 
> 2) Finding and fixing the wxGTK bug that causes a segfault whenever a
> DTML document is opened.  It's a stack overflow.
> HTMLSourceView.OnUpdateUI() calls HTMLStyledTextCtrlMix.OnUpdateUI(),
> which calls window.Refresh(), which generates another call to
> HTMLSourceView.OnUpdateUI().  I commented out the call to Refresh().
> Shouldn't wxStyledTextCtrl be doing the equivalent of the Refresh()
> operation automatically?

The new wxStyledTextCtrl also sorts out the reason I had to refresh.
Previously to match braces that were not on the same line the control
had to refreshed.
I had already found this bug, (I didn't know why it crashed tho)
but didn't apply the check on the HTML view because I don't have a 
Zope on my Linux box, and never tested any of the Zope stuff on Linux,
so I forgot.
There is a flag in PrefsGTK.py, braceHighLight = 0
This turns off refreshing on GTK for Python Source and the Shell.
The usual check is in Views.PySourceView.PythonSourceView.OnUpdateUI.
Bracehighlighting in HTML isn't working so most of 
Views.StyledTextCtrls.HTMLStyledTextCtrlMix.OnUpdateUI can actually go.

> 
> 3) Reformatting some of the code to look better in emacs.
> 
> I wonder if you would consider adding a developer to the project so that
> I can just check in the changes.

You're added, welcome!
The CVS should start working next time SourceForge updates.
Please check the changes in.
This will also give me the chance to test the new CVS update/commit 
features in Boa ;)

-- 
Riaan Booysen
___________________________________________________
Boa Constructor - RAD GUI building IDE for wxPython
     http://boa-constructor.sourceforge.net