Re: [Boa Constr] Removing options for wx.DIALOG_MODAL and wx.DIALOG_MODELESS

[Werner F. B. <wer...@fr...>]

Chris,

On 27/11/2010 18:32, Chris Spencer wrote:
> wx.DIALOG_MODAL and wx.DIALOG_MODELESS have been removed as of
> wxPython 2.9.  It is dangerous (and unnecessary) to leave them in Boa
> Constructor.  Therefore, in the file FrameCompanions.py, replace...
>
> class DialogDTC(FramesConstr, BaseFrameDTC):
>      dialogLayout = True
>
>      def __init__(self, name, designer, frameCtrl):
>          BaseFrameDTC.__init__(self, name, designer, frameCtrl)
>          self.windowStyles = ['wx.DIALOG_MODAL', 'wx.DIALOG_MODELESS',
>                'wx.CAPTION', 'wx.DEFAULT_DIALOG_STYLE',
> 'wx.RESIZE_BORDER',
>                'wx.THICK_FRAME', 'wx.STAY_ON_TOP',
> 'wx.DIALOG_NO_PARENT',
>                'wx.SYSTEM_MENU', 'wx.CLOSE_BOX']\
>                + self.windowStyles
>
> with...
>
> class DialogDTC(FramesConstr, BaseFrameDTC):
>      dialogLayout = True
>
>      def __init__(self, name, designer, frameCtrl):
>          BaseFrameDTC.__init__(self, name, designer, frameCtrl)
>          self.windowStyles = [
>                'wx.CAPTION', 'wx.DEFAULT_DIALOG_STYLE',
> 'wx.RESIZE_BORDER',
>                'wx.THICK_FRAME', 'wx.STAY_ON_TOP',
> 'wx.DIALOG_NO_PARENT',
>                'wx.SYSTEM_MENU', 'wx.CLOSE_BOX']\
>                + self.windowStyles
>
> (just removing wx.DIALOG_MODAL and wx.DIALOG_MODELESS references)
Shouldn't changes like this be conditioned by Version?  I.e. if one is 
on wxPython 2.8 or lower this is still active otherwise not.

There is already quite a big of "if wx.VERSION[:2] >= (2, 7):" type code 
in there.


Werner