boa-constructor-users

[Boa Constr] Tab-key in PySourceView

[Mike C. F. <mcf...@ho...>]

Hi all,  looking at the tab-key handler in PySourceView (line 984), it could
use some enhancements.  These are patterned after the PythonWin interactions
(IDLE too if I recall), and make the indent/dedent operations with the tab
key much more natural feeling.

My attempts to integrate the changes have failed. I can't seem to get the
PySourceView to actually use my modified function (so I haven't actually
tested it to see if it works).  Although the OnKeyDown method appears like
the correct customisation point, it doesn't actually seem to get called.

	tab -- should be translated to an indent command if within the leading
whitespace of the line and there's no selection
	shift-tab -- should be translated to a dedent command if within the leading
whitespace of the line and there's no selection
	if there is a multi-line selection, then both indent and dedent (tab and
shift-tab) should operate on the selection.

Are there a lot of these 2600 line files around?
Mike

8<___________ PySourceView line 984 +
        # Tabbed indent
        elif key == 9:
            print 'tab key'
            # revised tab semantics mcfletch 2001
            if event.ShiftDown():
                print 'shift down'
                # is a dedent request
                self.OnDedent(event)
            else:
                # is likely an indent request
                # will consider it an ident request if we're actually
                # in the indentation section or we have a non-null selection
                # set...
                # selection set?
                start, stop = self.GetSelection()
                pos = self.GetCurrentPos()
                startPosition =
self.GetLineStartPos(self.GetLineFromPos(pos))
                line = self.GetLineFromPos(pos)
                prefix = string.strip(line[:(pos-startPosition)])
                def updatePosition( self, position ):
                    if old_stc:
                        self.SetCurrentPosition(position)
                    else:
                        self.SetSelectionStart(pos + indentLevel)
                if (start == stop):
                    # is a tab-key in the indentation section,
                    # update the indentation to be one level deeper...
                    if prefix:
                        # there is a non-whitespace character in front of
position,
                        # insert an actual tab character
                        self.InsertText(pos, '\t')
                        updatePosition( self, pos + 1 )
                    else:
                        # do an indent by inserting some whitespace
                        self.InsertText(pos, indentLevel*' ')
                        updatePosition( self, pos + indentLevel )
                else:
                    # non-null selection set...
                    self.OnIndent(event)
            if not self.AutoCompActive(): return

__________________________________
 Mike C. Fletcher
 Designer, VR Plumber
 http://members.home.com/mcfletch

Re: [Boa Constr] Tab-key in PySourceView

[Riaan B. <riaan@e.co.za>]

Hi Mike, this is a quick note just to let you know I am here but still
busy with the replies to your (and others') previous messages.
I've addressed some of your issues and fixed bugs that have been
reported since the release and hope to post the replies (and CVS)
tonight. I've added tab, shift-tab/indent, dedent support.

"Mike C. Fletcher" wrote:
> 
> Hi all,  looking at the tab-key handler in PySourceView (line 984), it could
> use some enhancements.  These are patterned after the PythonWin interactions
> (IDLE too if I recall), and make the indent/dedent operations with the tab

Idle uses Ctrl-] and Ctrl-[ (Which can't be bound to an accelerator 
table)

> key much more natural feeling.
> 
> My attempts to integrate the changes have failed. I can't seem to get the
> PySourceView to actually use my modified function (so I haven't actually
> tested it to see if it works).  Although the OnKeyDown method appears like
> the correct customisation point, it doesn't actually seem to get called.

Did you also binf it in PrefsKeys.py ?
I've explained this in my other message, in short; If a key is bound to
an accelerator table, it does not generate further events for the
control.

> 
>         tab -- should be translated to an indent command if within the leading
> whitespace of the line and there's no selection
>         shift-tab -- should be translated to a dedent command if within the leading
> whitespace of the line and there's no selection
>         if there is a multi-line selection, then both indent and dedent (tab and
> shift-tab) should operate on the selection.
> 
> Are there a lot of these 2600 line files around?
> Mike

Be fair, it's a 1280 line file (50k), and there 7 source files in the 
distribution bigger than 45k.
My usual rule of thumb is to not let a file get longer than 1000 lines,
although there are a few.

> 
> 8<___________ PySourceView line 984 +
>         # Tabbed indent
>         elif key == 9:
>             print 'tab key'
>             # revised tab semantics mcfletch 2001
>             if event.ShiftDown():
>                 print 'shift down'
>                 # is a dedent request
>                 self.OnDedent(event)
>             else:
>                 # is likely an indent request
>                 # will consider it an ident request if we're actually
>                 # in the indentation section or we have a non-null selection
>                 # set...
>                 # selection set?
>                 start, stop = self.GetSelection()
>                 pos = self.GetCurrentPos()
>                 startPosition =
> self.GetLineStartPos(self.GetLineFromPos(pos))
>                 line = self.GetLineFromPos(pos)
>                 prefix = string.strip(line[:(pos-startPosition)])
>                 def updatePosition( self, position ):
>                     if old_stc:
>                         self.SetCurrentPosition(position)
>                     else:
>                         self.SetSelectionStart(pos + indentLevel)
>                 if (start == stop):
>                     # is a tab-key in the indentation section,
>                     # update the indentation to be one level deeper...
>                     if prefix:
>                         # there is a non-whitespace character in front of
> position,
>                         # insert an actual tab character
>                         self.InsertText(pos, '\t')
>                         updatePosition( self, pos + 1 )
>                     else:
>                         # do an indent by inserting some whitespace
>                         self.InsertText(pos, indentLevel*' ')
>                         updatePosition( self, pos + indentLevel )
>                 else:
>                     # non-null selection set...
>                     self.OnIndent(event)
>             if not self.AutoCompActive(): return
> 
> __________________________________
>  Mike C. Fletcher
>  Designer, VR Plumber
>  http://members.home.com/mcfletch
> 
> _______________________________________________
> Boa-constructor-users mailing list
> Boa...@li...
> http://lists.sourceforge.net/lists/listinfo/boa-constructor-users

-- 
Riaan Booysen
___________________________________________________
Boa Constructor - RAD GUI building IDE for wxPython
     http://boa-constructor.sourceforge.net

RE: [Boa Constr] Tab-key in PySourceView

[Mike C. F. <mcf...@ho...>]

Hi Riaan,

Thanks for the reassurance (and the work) :) .

I didn't realise there was a requirement to bind it in PrefsKeys.

As for the long file comment, it was more a "Oh my God, I'll never figure it
out" comment, not a "don't do that" comment.  I'm not a programmer by
profession, so big blocks of code written by someone else always seem
daunting to me :) .  I wanted to know if there's more dragons waiting in the
wings to make me feel inadequate :o) .

Enjoy,
Mike



-----Original Message-----
From: Riaan Booysen [mailto:riaan@e.co.za]
Sent: Saturday, April 07, 2001 16:00
To: Mike C. Fletcher
Cc: Boa Constructor (E-mail)
Subject: Re: [Boa Constr] Tab-key in PySourceView
...
Did you also binf it in PrefsKeys.py ?
I've explained this in my other message, in short; If a key is bound to
an accelerator table, it does not generate further events for the
control.
...
Be fair, it's a 1280 line file (50k), and there 7 source files in the
distribution bigger than 45k.
My usual rule of thumb is to not let a file get longer than 1000 lines,
although there are a few.
...