Re: CVS: blob/src/blob compr_rtime.c,NONE,1.1 compr_rubin.c,NONE,1.1 compr_zlib.c,NONE,1.1 cramfs.c,NONE,1.1 jffs2.c,NONE,1.1 load_kernel.c,NONE,1.1 mini_inflate.c,NONE,1.1 zImage.c,NONE,1.1 Makefile.am,1.22,1.23 main.c,1.31,1.32

[Erik M. <J.A...@it...>]

On Thu, Feb 14, 2002 at 01:59:36AM -0800, Tim Riker wrote:
> Update of /cvsroot/blob/blob/src/blob
> In directory usw-pr-cvs1:/tmp/cvs-serv27294/src/blob
> 
> Modified Files:
> 	Makefile.am main.c 
> Added Files:
> 	compr_rtime.c compr_rubin.c compr_zlib.c cramfs.c jffs2.c 
> 	load_kernel.c mini_inflate.c zImage.c 
> Log Message:
> most of Russ's jffs2 code updated

A couple of remarks:

- Be *extremely* careful with inline functions, they can really bloat
  the generated code.
- We already have quite some functions available. For example: I'd
  rather have a generic memset() function in src/lib/ and #define
  cramfs_memset as memset.
- What is ZIMAGE support supposed to do? I guess it's to load directly
  from flash partitions, but in that case the name is wrong.
- Checking for the ZIMAGE magic is a bad idea. It doesn't allow you to
  load diag anymore, for example (yes, it has a hack to look like a
  kernel, but that's ugly). Oh, and the so called "magic value" is
  nowhere documented so don't rely on it.


Erik

-- 
J.A.K. (Erik) Mouw, Information and Communication Theory Group, Faculty
of Information Technology and Systems, Delft University of Technology,
PO BOX 5031, 2600 GA Delft, The Netherlands  Phone: +31-15-2783635
Fax: +31-15-2781843  Email: J.A...@it...
WWW: http://www-ict.its.tudelft.nl/~erik/