Re: CVS: blob/src/lib serial.c,1.7,1.8

[Erik M. <J.A...@it...>]

On Wed, Feb 06, 2002 at 09:31:30AM +0200, Abraham vd Merwe wrote:
> Hi Erik!
> 
> > > Update of /cvsroot/blob/blob/src/lib
> > > In directory usw-pr-cvs1:/tmp/cvs-serv15305/src/lib
> > > 
> > > Modified Files:
> > > 	serial.c 
> > > Log Message:
> > > Added a printf()-like function for printing to the serial port. Also some
> > > minor code cleanup in the memory checking routines.
> > 
> > I'd prefer if you could move it to src/lib/printf.c and just call the
> > function printf(). No difference in functionality, but it makes the
> > source easier to browse and to read.
> 
> As you might have seen, I backed out the changes in anycase since there's no
> portable way to do variable arguments (I realised that after I wrote the
> damn function) and we don't include the standard C library headers.

Yeah, I realised that too late.

> I looked at the way diet libc does it's stdarg.h, but that is a great
> example of why you don't want to write your own stdarg routines :P (Besides
> the fact that those routines doesn't work for uncast numeric parameters e.g.
> printf("%x",15); )
> 
> > PS: If this is Brad Parker's printf() be sure to put a correct
> >   copyright on top of the file. The last thing we want is copyright
> >   issues.
> 
> No, I wrote that one yesterday.

You might want to look at Brad's IDE code, it contains a printf()
implementation and he somehow solved the stdarg problem. IIRC he posted
the URL to the LART mailing list.


Erik

-- 
J.A.K. (Erik) Mouw, Information and Communication Theory Group, Faculty
of Information Technology and Systems, Delft University of Technology,
PO BOX 5031, 2600 GA Delft, The Netherlands  Phone: +31-15-2783635
Fax: +31-15-2781843  Email: J.A...@it...
WWW: http://www-ict.its.tudelft.nl/~erik/