Re: [binarycloud-dev] QueryManager

[Alex B. <en...@tu...>]

> I just startet to optimize the code to fit with r2. Mostly convention
> changes and connectivity with $gDatasources.
> 
> I guess on monday its cleaned up and usable like this:
> 
> import('binarycloud.mgr.QueryManager');
> $qm = new QueryManager('my_datasrc_hook');
> 
> $query = array('QUERY' => 'SELECT foo, bar FROM table....balh');
> $values = $qm->DoCustomQuery($query, "", true);
> 
> I have to do minor changes to metabase drivers (GetColumnNames(), oci
> already supports this). QM:_ProccessResult does need this. The alternative
> is to implement the database specific functions that are required directly
> into QM, but I don't like this.
> 
> Alex, anything specific I have to take care of when r2ifying the code?

hi Andreas,

to be honest I have only "cleaned" it - I have not studied the code enough
to give you a real opinion.

I can say that I would prefer that datasources not be a global variable -
because they will contain passwords, sids, etc.

If you look at user/conf/langs.php - you'll see that it sets a cariable in
the lang class: I'd like to have it happen the same way with QueryManager.

-------

Re changes to the metabase drivers:

    -John D, JPC? Did you have to do this?

Andreas: we might be using a slightly old version of metabase... let me
check phpclasses and get back to you :)

-a