[Bigsister-devel] change proposal

[<pet...@fi...>]

Hello,

I propose a minor change to the BigSister configuration language:

diff -u big-sister-1.02/bsmonitor/Statusmon/DisplayCFG.pm
/data/bigsis-test/bin/Statusmon/DisplayCFG.pm
--- big-sister-1.02/bsmonitor/Statusmon/DisplayCFG.pm   2005-10-13
15:15:27.000000000 +0200
+++ /data/bigsis-test/bin/Statusmon/DisplayCFG.pm       2006-06-30
16:14:24.147125168 +0200
@@ -275,7 +275,7 @@
                else {
                    $args{"refto"} = $args[0];
                    unless( $args{"refto"} =~ /\.htm/ ) { $args{"refto"} .
= ".html"; };
-                   $args{"refto"} .= "#";
+                   unless( $args{"refto"} =~ /=$/ ) {$args{"refto"} .= "
#";};
                }
            }
            elsif( ($cmd eq "skin") || ($cmd eq "Logskin") ) {

This permits to use things like "%refto notes/hostinfo.html?server=" in
bb-display.cfg, where hostinfo.html can now trigger execution of a cgi
script that is provided with the hostname as a parameter.
I don't expect this change to break anything.

Another minor change:

 diff -u big-sister-1.02/modules/dbstore/bin/DBCapsulator/DBI.pm
/data/bigsis-test/bin/DBCapsulator/DBI.pm
--- big-sister-1.02/modules/dbstore/bin/DBCapsulator/DBI.pm     2006-01-17
14:46:35.000000000 +0100
+++ /data/bigsis-test/bin/DBCapsulator/DBI.pm   2006-07-07
19:26:43.802112751 +0200
@@ -19,6 +19,7 @@
     $self->dbh( $dbh );
     my $table = $self->dbcfg()->{"table"};
     my @names = $dbh->tables( undef, undef, $table, undef );
+    grep ( y/"//d, @names );
     my @names = grep( /^(|.*\W)$table(\W.*|)$/, @names );
     unless( @names ) {
         $self->create_table() || die "table $table does not exist in
$dbcfg->{'datasource'} and create table did not succeed";

This helps to use DB2 for the performance data store. In DB2, table names
are made up of two parts, the "Schema" name and the table name itself. The
Schema name, if not specified, defaults to the current user name. This is
mostly fine, but when the bshistgraph executes in the web server context,
the user is, e.g., "www" while the tables were created by the user
"bigsister". So, in db.cfg, I specify full table names, e.g.
BIGSISTER.BSPERF. But DBI->tables() sadly returns this as
"BIGSISTER"."BSPERF" including the quotes. My patch strips off these
quotes, and everything works as intended. I am not sure, however, that this
does not break other database connectors.


Regards,

Peter Hettkamp