Bidwatcher / Patches / #29 error in syncing upto 1.3.9

#29 error in syncing upto 1.3.9

Status: closed-fixed

Owner: Kevin Dwyer

Labels: None

Priority: 5

Updated: 2003-10-29

Created: 2003-07-16

Creator: Uwe Klein

Private: No

the buffer in calcTimeDiff ( lineBuff ) is
a bit too short.
the ch* buffers are filled through strcpy
and can overflow

Discussion

Uwe Klein - 2003-07-16

fixes syncerror for current ebay timepage ( 2003/07/16 )

bidwatcher-1.2.8:syncerr.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kevin Dwyer - 2003-07-17

Logged In: YES
user_id=285914

Yeah I fixed this a while ago but the anonymous CVS is
working off of the backup server. I'll look at the overflow
too, that one I hadn't considered. I probably won't use the
hex values you use though. ;)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kevin Dwyer - 2003-07-17

assigned_to: nobody --> kevindication

status: open --> open-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Uwe Klein - 2003-07-17

Logged In: YES
user_id=136222

Just pick your own ;-)

while going through helpers.cpp i noticed
quite a lot hardcoded bufferlen's.
should i send you a patch in a day or 4
with bufferlen extracted to a #define and
strcpy and friends changed to strncpy?

G!
UK

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kevin Dwyer - 2003-10-29

status: open-fixed --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kevin Dwyer - 2003-10-29

Logged In: YES
user_id=285914

This was more or less done back when eBay broke. Thanks for
the patch.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.