bibdesk-commit — This tracks source code changes in Subversion.

[Bibdesk-commit] SF.net SVN: bibdesk:[28948] trunk/bibdesk/BDSKCondition.m

[<ho...@us...>]

Revision: 28948
          http://sourceforge.net/p/bibdesk/svn/28948
Author:   hofman
Date:     2024-09-17 14:38:18 +0000 (Tue, 17 Sep 2024)
Log Message:
-----------
interpret missing date-added or date-modified for smart group conditions as far into the past

Modified Paths:
--------------
    trunk/bibdesk/BDSKCondition.m

Modified: trunk/bibdesk/BDSKCondition.m
===================================================================
--- trunk/bibdesk/BDSKCondition.m	2024-09-06 12:37:59 UTC (rev 28947)
+++ trunk/bibdesk/BDSKCondition.m	2024-09-17 14:38:18 UTC (rev 28948)
@@ -220,8 +220,8 @@
             date = [item dateAdded];
         else if ([key isEqualToString:BDSKDateModifiedString])
             date = [item dateModified];
-        return ((cachedStartDate == nil || [date compare:cachedStartDate] != NSOrderedAscending) &&
-                (cachedEndDate == nil || [date compare:cachedEndDate] == NSOrderedAscending));
+        return (cachedStartDate == nil || (date && [date compare:cachedStartDate] != NSOrderedAscending)) &&
+                (cachedEndDate == nil || (date == nil || [date compare:cachedEndDate] == NSOrderedAscending));
         
     } else if ([self isAttachmentCondition]) {
         

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Bibdesk-commit] SF.net SVN: bibdesk:[28947] trunk/bibdesk

[<ho...@us...>]

Revision: 28947
          http://sourceforge.net/p/bibdesk/svn/28947
Author:   hofman
Date:     2024-09-06 12:37:59 +0000 (Fri, 06 Sep 2024)
Log Message:
-----------
NS encoding is 0 when invalid, not CF invalid

Modified Paths:
--------------
    trunk/bibdesk/BDSKAsynchronousWebParser.m
    trunk/bibdesk/BDSKDBLPGroupServer.m
    trunk/bibdesk/BDSKDOIParser.m
    trunk/bibdesk/BDSKMODSParser.m
    trunk/bibdesk/BDSKTextImportController.m
    trunk/bibdesk/BDSKWebGroup.m

Modified: trunk/bibdesk/BDSKAsynchronousWebParser.m
===================================================================
--- trunk/bibdesk/BDSKAsynchronousWebParser.m	2024-08-26 14:38:58 UTC (rev 28946)
+++ trunk/bibdesk/BDSKAsynchronousWebParser.m	2024-09-06 12:37:59 UTC (rev 28947)
@@ -205,7 +205,7 @@
     NSString *encodingName = [[download response] textEncodingName];
     NSStringEncoding encoding = [NSString encodingForIANACharSetName:encodingName];
     
-    if (encoding != kCFStringEncodingInvalidId)
+    if (encoding != 0)
         string = [[NSString alloc] initWithData:data encoding:encoding];
     if (nil == string && encoding != NSUTF8StringEncoding)
         string = [[NSString alloc] initWithData:data encoding:NSUTF8StringEncoding];

Modified: trunk/bibdesk/BDSKDBLPGroupServer.m
===================================================================
--- trunk/bibdesk/BDSKDBLPGroupServer.m	2024-08-26 14:38:58 UTC (rev 28946)
+++ trunk/bibdesk/BDSKDBLPGroupServer.m	2024-09-06 12:37:59 UTC (rev 28947)
@@ -330,9 +330,7 @@
         if (i != NSNotFound) {
             isBibTeX = YES;
             NSString *encodingName = [response textEncodingName];
-            NSStringEncoding nsEncoding = [NSString encodingForIANACharSetName:encodingName];
-            if (nsEncoding == kCFStringEncodingInvalidId)
-                nsEncoding = NSUTF8StringEncoding;
+            NSStringEncoding nsEncoding = [NSString encodingForIANACharSetName:encodingName] ?: NSUTF8StringEncoding;
             NSString *btString = [[NSString alloc] initWithData:data encoding:nsEncoding];
             pubs = [BDSKBibTeXParser itemsFromString:btString owner:group error:NULL];
             [bibtexFetches replaceObjectAtIndex:i withObject:pubs];

Modified: trunk/bibdesk/BDSKDOIParser.m
===================================================================
--- trunk/bibdesk/BDSKDOIParser.m	2024-08-26 14:38:58 UTC (rev 28946)
+++ trunk/bibdesk/BDSKDOIParser.m	2024-09-06 12:37:59 UTC (rev 28947)
@@ -83,9 +83,7 @@
     BibItem *item = nil;
     if (data) {
         NSString *bibtexString = nil;
-        NSStringEncoding encoding = [NSString encodingForIANACharSetName:encodingName];
-        if (encoding == kCFStringEncodingInvalidId)
-            encoding = NSUTF8StringEncoding;
+        NSStringEncoding encoding = [NSString encodingForIANACharSetName:encodingName] ?: NSUTF8StringEncoding;
         bibtexString = [[[NSString alloc] initWithData:data encoding:encoding] stringByRemovingSurroundingWhitespace];
         if (bibtexString && [BDSKBibTeXParser canParseString:bibtexString]) {
             NSError *error = nil;

Modified: trunk/bibdesk/BDSKMODSParser.m
===================================================================
--- trunk/bibdesk/BDSKMODSParser.m	2024-08-26 14:38:58 UTC (rev 28946)
+++ trunk/bibdesk/BDSKMODSParser.m	2024-09-06 12:37:59 UTC (rev 28947)
@@ -73,9 +73,7 @@
     
     NSData *xmlData = [marcDoc XMLData];
     NSString *encodingName = [marcDoc characterEncoding];
-    NSStringEncoding encoding = [NSString encodingForIANACharSetName:encodingName];
-    if (encoding == kCFStringEncodingInvalidId)
-        encoding = NSUTF8StringEncoding;
+    NSStringEncoding encoding = [NSString encodingForIANACharSetName:encodingName] ?: NSUTF8StringEncoding;
     
     NSString *xmlString = [[NSString alloc] initWithData:xmlData encoding:encoding];
     NSArray *parsedItems = [BDSKMARCParser itemsFromMARCXMLString:xmlString error:outError];

Modified: trunk/bibdesk/BDSKTextImportController.m
===================================================================
--- trunk/bibdesk/BDSKTextImportController.m	2024-08-26 14:38:58 UTC (rev 28946)
+++ trunk/bibdesk/BDSKTextImportController.m	2024-09-06 12:37:59 UTC (rev 28947)
@@ -1393,9 +1393,7 @@
         
         if(string == nil) {
             NSString *encodingName = [dataSource textEncodingName];
-            NSStringEncoding nsEncoding = [NSString encodingForIANACharSetName:encodingName];
-            if (nsEncoding == kCFStringEncodingInvalidId)
-                nsEncoding = NSUTF8StringEncoding;
+            NSStringEncoding nsEncoding = [NSString encodingForIANACharSetName:encodingName] ?: NSUTF8StringEncoding;
             string = [[NSString alloc] initWithData:[dataSource data] encoding:nsEncoding];
         }
         

Modified: trunk/bibdesk/BDSKWebGroup.m
===================================================================
--- trunk/bibdesk/BDSKWebGroup.m	2024-08-26 14:38:58 UTC (rev 28946)
+++ trunk/bibdesk/BDSKWebGroup.m	2024-09-06 12:37:59 UTC (rev 28947)
@@ -271,7 +271,7 @@
             if(string == nil) {
                 NSData *data = [dataSource data];
                 NSString *encodingName = [dataSource textEncodingName];
-                NSStringEncoding encoding = encodingName ? [NSString encodingForIANACharSetName:encodingName] : NSUTF8StringEncoding;
+                NSStringEncoding encoding = [NSString encodingForIANACharSetName:encodingName] ?: NSUTF8StringEncoding;
                 if (encoding != kCFStringEncodingInvalidId)
                     string = [[NSString alloc] initWithData:data encoding:encoding];
                 if (nil == string && encoding != NSUTF8StringEncoding)

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Bibdesk-commit] SF.net SVN: bibdesk:[28946] trunk/bibdesk

[<ho...@us...>]

Revision: 28946
          http://sourceforge.net/p/bibdesk/svn/28946
Author:   hofman
Date:     2024-08-26 14:38:58 +0000 (Mon, 26 Aug 2024)
Log Message:
-----------
BDSKShouldShowWebGroup is not used anymore

Modified Paths:
--------------
    trunk/bibdesk/BDSKStringConstants.m
    trunk/bibdesk/Preferences.plist

Modified: trunk/bibdesk/BDSKStringConstants.m
===================================================================
--- trunk/bibdesk/BDSKStringConstants.m	2024-08-25 16:46:34 UTC (rev 28945)
+++ trunk/bibdesk/BDSKStringConstants.m	2024-08-26 14:38:58 UTC (rev 28946)
@@ -362,7 +362,6 @@
  BDSKTableCellImages                             dict    nil
  BDSKGroupFieldSeparatorCharactersKey            string  ";:,"
  BDSKDefaultGroupFieldSeparatorKey               string  "; "    // note trailing space!
- BDSKShouldShowWebGroup                          bool    true
  BDSKEditorFormShouldAutoCompleteKey             bool    true
  BDSKAdditionalFieldsToComplete                  array   nil
  BDSKReadExtendedAttributesKey                   bool    false   // read/write BibTeX to files

Modified: trunk/bibdesk/Preferences.plist
===================================================================
--- trunk/bibdesk/Preferences.plist	2024-08-25 16:46:34 UTC (rev 28945)
+++ trunk/bibdesk/Preferences.plist	2024-08-26 14:38:58 UTC (rev 28946)
@@ -128,8 +128,6 @@
 					</array>
 					<key>BDSKSearchMenuTagKey</key>
 					<integer>0</integer>
-					<key>BDSKShouldShowWebGroup</key>
-					<true/>
 					<key>BDSKShouldUsePDFMetadata</key>
 					<false/>
 					<key>BDSKShouldUsePubMedMetadata</key>

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Bibdesk-commit] SF.net SVN: bibdesk:[28945] trunk/bibdesk/BDSKWebGrou p.m

[<ho...@us...>]

Revision: 28945
          http://sourceforge.net/p/bibdesk/svn/28945
Author:   hofman
Date:     2024-08-25 16:46:34 +0000 (Sun, 25 Aug 2024)
Log Message:
-----------
Don't register bibdesk scheme as local, for some reason that stops it from working in links

Modified Paths:
--------------
    trunk/bibdesk/BDSKWebGroup.m

Modified: trunk/bibdesk/BDSKWebGroup.m
===================================================================
--- trunk/bibdesk/BDSKWebGroup.m	2024-08-25 15:57:02 UTC (rev 28944)
+++ trunk/bibdesk/BDSKWebGroup.m	2024-08-25 16:46:34 UTC (rev 28945)
@@ -83,7 +83,6 @@
 	
     // register for bibdesk: protocol, so we can display a help page on start
 	[NSURLProtocol registerClass:[BDSKBibDeskProtocol class]];
-	[WebView registerURLSchemeAsLocal:BDSKBibDeskScheme];	
     [WebView setMIMETypesShownAsHTML:[[WebView MIMETypesShownAsHTML] arrayByAddingObjectsFromArray:@[@"application/x-bibtex", @"application/x-research-info-systems", @"application/x-endnote-refer"]]];
 }
 

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Bibdesk-commit] SF.net SVN: bibdesk:[28944] trunk/bibdesk/BDSKWebPars er.m

[<ho...@us...>]

Revision: 28944
          http://sourceforge.net/p/bibdesk/svn/28944
Author:   hofman
Date:     2024-08-25 15:57:02 +0000 (Sun, 25 Aug 2024)
Log Message:
-----------
Don't use NSPredicate for class objeccts

Modified Paths:
--------------
    trunk/bibdesk/BDSKWebParser.m

Modified: trunk/bibdesk/BDSKWebParser.m
===================================================================
--- trunk/bibdesk/BDSKWebParser.m	2024-08-25 14:54:34 UTC (rev 28943)
+++ trunk/bibdesk/BDSKWebParser.m	2024-08-25 15:57:02 UTC (rev 28944)
@@ -144,7 +144,11 @@
 }
 
 + (NSArray *)parsersForFeature:(BDSKParserFeature)feature {
-    return [[self parsers] filteredArrayUsingPredicate:[NSPredicate predicateWithFormat:@"feature = %lu", (unsigned long)feature]];
+    NSMutableArray *parsers = [NSMutableArray array];
+    for (Class parserClass in [self parsers])
+        if ([parserClass feature] == feature)
+            [parsers addObject:parserClass];
+    return parsers;
 }
 
 + (NSArray *)publicParsers { return [self parsersForFeature:BDSKParserFeaturePublic]; }

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Bibdesk-commit] SF.net SVN: bibdesk:[28943] trunk/bibdesk/Preferences .plist

[<ho...@us...>]

Revision: 28943
          http://sourceforge.net/p/bibdesk/svn/28943
Author:   hofman
Date:     2024-08-25 14:54:34 +0000 (Sun, 25 Aug 2024)
Log Message:
-----------
make table cell images revertable

Modified Paths:
--------------
    trunk/bibdesk/Preferences.plist

Modified: trunk/bibdesk/Preferences.plist
===================================================================
--- trunk/bibdesk/Preferences.plist	2024-08-25 14:50:02 UTC (rev 28942)
+++ trunk/bibdesk/Preferences.plist	2024-08-25 14:54:34 UTC (rev 28943)
@@ -601,6 +601,8 @@
 					<dict/>
 					<key>BDSKTableHeaderTitles</key>
 					<dict/>
+					<key>BDSKTableCellImages - 2</key>
+					<dict/>
 					<key>BDSKUseLocalUrlAndUrlKey</key>
 					<false/>
 					<key>Boolean fields</key>

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Bibdesk-commit] SF.net SVN: bibdesk:[28942] trunk/bibdesk/BDSKStringC onstants.m

[<ho...@us...>]

Revision: 28942
          http://sourceforge.net/p/bibdesk/svn/28942
Author:   hofman
Date:     2024-08-25 14:50:02 +0000 (Sun, 25 Aug 2024)
Log Message:
-----------
update hidden pref key list

Modified Paths:
--------------
    trunk/bibdesk/BDSKStringConstants.m

Modified: trunk/bibdesk/BDSKStringConstants.m
===================================================================
--- trunk/bibdesk/BDSKStringConstants.m	2024-08-25 09:12:40 UTC (rev 28941)
+++ trunk/bibdesk/BDSKStringConstants.m	2024-08-25 14:50:02 UTC (rev 28942)
@@ -348,24 +348,23 @@
  BDSKRemoveExtendedAttributesFromDocuments       bool    false
  BDSKDisableDocumentExtendedAttributes           bool    false
  BDSKDisableExportAttributes                     bool    false
- BDSKFieldsToWriteIfEmpty                        array   ()
+ BDSKFieldsToWriteIfEmpty                        array   nil
  BDSKEnableSharingWithSelf                       bool    false   // developers only
  BDSKDisableRemoteChangeNotifications            bool    false
  BDSKSharingServerMaxConnections                 integer 0       // ignored if < 20
- BDSKDisableExceptionHandling                    bool    false   // developers only
  BDSKShouldLogFilesAddedToMatchingSearchIndex    bool    false   // developers only
  BDSKUseXMLSpotlightCache                        bool    false   // developers only
  BDSKScriptMenuDisabled                          bool    false
- BDSKAnnoteFieldName                             BDSKReadExtendedAttributesKey      string  nil
- BDSKDefaultAnimationTimeInterval                CGFloat   0.15    // set to zero to disable
+ BDSKAnnoteFieldName                             string  nil
+ BDSKDefaultAnimationTimeInterval                CGFloat 0.25    // set to zero to disable
  BDSKTableHeaderImages                           dict    nil
  BDSKTableHeaderTitles                           dict    nil
  BDSKTableCellImages                             dict    nil
  BDSKGroupFieldSeparatorCharactersKey            string  ";:,"
  BDSKDefaultGroupFieldSeparatorKey               string  "; "    // note trailing space!
- BDSKShouldShowWebGroup                          bool    false
+ BDSKShouldShowWebGroup                          bool    true
  BDSKEditorFormShouldAutoCompleteKey             bool    true
- BDSKAdditionalFieldsToComplete                  array   ()
+ BDSKAdditionalFieldsToComplete                  array   nil
  BDSKReadExtendedAttributesKey                   bool    false   // read/write BibTeX to files
  BDSKShouldUsePDFMetadataKey                     bool    false   // reads standard PDF info
  BDSKAddISIXMLStringToAnnote                     bool    false
@@ -374,7 +373,7 @@
  BDSKISIURLFieldName                             string  nil     // assign ISI URL to specified field
  BDSKDefaultArrayJoinString                      string  "/"
  BDSKShouldUsePubMedMetadataKey                  bool    true    // treat filename as PMID
- BDSKDefaultDefaultBrowserKey                    string  ""
+ BDSKDefaultBrowserKey                           string  nil
  BDSKSaveLinkedFilesAsRelativePathOnly           bool    false
  BDSKSaveLinkedFilesAsArchivedData               bool    false
  BDSKSaveLinkedFilesAsAlias                      bool    false

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Bibdesk-commit] SF.net SVN: bibdesk:[28941] trunk/bibdesk/BDSKStringC onstants.m

[<ho...@us...>]

Revision: 28941
          http://sourceforge.net/p/bibdesk/svn/28941
Author:   hofman
Date:     2024-08-25 09:12:40 +0000 (Sun, 25 Aug 2024)
Log Message:
-----------
update list of hidden pref keys

Modified Paths:
--------------
    trunk/bibdesk/BDSKStringConstants.m

Modified: trunk/bibdesk/BDSKStringConstants.m
===================================================================
--- trunk/bibdesk/BDSKStringConstants.m	2024-08-23 16:27:25 UTC (rev 28940)
+++ trunk/bibdesk/BDSKStringConstants.m	2024-08-25 09:12:40 UTC (rev 28941)
@@ -343,13 +343,12 @@
  
  ** Hidden pref keys **
  
- Last updated: Thu May 17 16:29:22 GMT 2007
+ Last updated: 25/12/2024
  
  BDSKRemoveExtendedAttributesFromDocuments       bool    false
  BDSKDisableDocumentExtendedAttributes           bool    false
  BDSKDisableExportAttributes                     bool    false
  BDSKFieldsToWriteIfEmpty                        array   ()
- BDSKShouldUseSpotlightCommentForURL             bool    false
  BDSKEnableSharingWithSelf                       bool    false   // developers only
  BDSKDisableRemoteChangeNotifications            bool    false
  BDSKSharingServerMaxConnections                 integer 0       // ignored if < 20
@@ -356,25 +355,31 @@
  BDSKDisableExceptionHandling                    bool    false   // developers only
  BDSKShouldLogFilesAddedToMatchingSearchIndex    bool    false   // developers only
  BDSKUseXMLSpotlightCache                        bool    false   // developers only
- BDSKDisableTypeAheadSelection                   bool    false
- BDSKDisableBackgroundColorForGroupTable         bool    false
  BDSKScriptMenuDisabled                          bool    false
- BDSKAnnoteFieldName                             string  nil
+ BDSKAnnoteFieldName                             BDSKReadExtendedAttributesKey      string  nil
  BDSKDefaultAnimationTimeInterval                CGFloat   0.15    // set to zero to disable
  BDSKTableHeaderImages                           dict    nil
  BDSKTableHeaderTitles                           dict    nil
+ BDSKTableCellImages                             dict    nil
  BDSKGroupFieldSeparatorCharactersKey            string  ";:,"
  BDSKDefaultGroupFieldSeparatorKey               string  "; "    // note trailing space!
  BDSKShouldShowWebGroup                          bool    false
  BDSKEditorFormShouldAutoCompleteKey             bool    true
+ BDSKAdditionalFieldsToComplete                  array   ()
  BDSKReadExtendedAttributesKey                   bool    false   // read/write BibTeX to files
- BDSKShouldUsePDFMetadataKey                        bool    false   // reads standard PDF info
+ BDSKShouldUsePDFMetadataKey                     bool    false   // reads standard PDF info
  BDSKAddISIXMLStringToAnnote                     bool    false
  BDSKDisableISITitleCasing                       bool    false
  BDSKISISourceXMLTagPriority                     array   nil
  BDSKISIURLFieldName                             string  nil     // assign ISI URL to specified field
  BDSKDefaultArrayJoinString                      string  "/"
- BDSKShouldUsePubMedMetadataKey                     bool    true    // treat filename as PMID
-
+ BDSKShouldUsePubMedMetadataKey                  bool    true    // treat filename as PMID
+ BDSKDefaultDefaultBrowserKey                    string  ""
+ BDSKSaveLinkedFilesAsRelativePathOnly           bool    false
+ BDSKSaveLinkedFilesAsArchivedData               bool    false
+ BDSKSaveLinkedFilesAsAlias                      bool    false
+ BDSKEnableGoogleScholarWebParser                bool    false
+ BDSKMatchAuthorNamesExactly                     bool    false
+ 
  */
 

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Bibdesk-commit] SF.net SVN: bibdesk:[28940] trunk/bibdesk/build_rel ease.py

[<ho...@us...>]

Revision: 28940
          http://sourceforge.net/p/bibdesk/svn/28940
Author:   hofman
Date:     2024-08-23 16:27:25 +0000 (Fri, 23 Aug 2024)
Log Message:
-----------
replace <v> or <version> by version in out directory for build scrript

Modified Paths:
--------------
    trunk/bibdesk/build_release.py

Modified: trunk/bibdesk/build_release.py
===================================================================
--- trunk/bibdesk/build_release.py	2024-08-23 14:46:16 UTC (rev 28939)
+++ trunk/bibdesk/build_release.py	2024-08-23 16:27:25 UTC (rev 28940)
@@ -598,6 +598,10 @@
     else:
             sys.stderr.write("\nWARNING: built product will not be notarized\n\n")
     
+    out = out.replace("<v>", new_version_string)
+    out = out.replace("<version>", new_version_string)
+    out = os.path.expanduser(out)
+    
     try:
         # probably already exists
         os.makedirs(out)

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Bibdesk-commit] SF.net SVN: bibdesk:[28939] trunk/bibdesk/build_rel ease.py

[<ho...@us...>]

Revision: 28939
          http://sourceforge.net/p/bibdesk/svn/28939
Author:   hofman
Date:     2024-08-23 14:46:16 +0000 (Fri, 23 Aug 2024)
Log Message:
-----------
Don't add spaces at end of release notes in appcast

Modified Paths:
--------------
    trunk/bibdesk/build_release.py

Modified: trunk/bibdesk/build_release.py
===================================================================
--- trunk/bibdesk/build_release.py	2024-08-21 15:57:04 UTC (rev 28938)
+++ trunk/bibdesk/build_release.py	2024-08-23 14:46:16 UTC (rev 28939)
@@ -471,7 +471,7 @@
     <channel>
         <item>
             <title>Version """ + newVersionString + """</title>
-            <description><![CDATA[""" + relNotes + """            ]]></description>
+            <description><![CDATA[""" + relNotes + """]]></description>
             <pubDate>""" + appcastDate + """</pubDate>
             <sparkle:minimumSystemVersion>""" + minimumSystemVersion + """</sparkle:minimumSystemVersion>
             <enclosure url=\"""" + download_url + """\" sparkle:version=\"""" + newVersion + """\" sparkle:shortVersionString=\"""" + newVersionString + """\" type=\"""" + type + """\" """ + signatureAndSize + """ />

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Bibdesk-commit] SF.net SVN: bibdesk:[28938] trunk/bibdesk/BibDesk.h elp/Contents/Resources/en.lproj/bibdesk.texi

[<ho...@us...>]

Revision: 28938
          http://sourceforge.net/p/bibdesk/svn/28938
Author:   hofman
Date:     2024-08-21 15:57:04 +0000 (Wed, 21 Aug 2024)
Log Message:
-----------
update copyrright date in help

Modified Paths:
--------------
    trunk/bibdesk/BibDesk.help/Contents/Resources/en.lproj/bibdesk.texi

Modified: trunk/bibdesk/BibDesk.help/Contents/Resources/en.lproj/bibdesk.texi
===================================================================
--- trunk/bibdesk/BibDesk.help/Contents/Resources/en.lproj/bibdesk.texi	2024-08-19 09:24:11 UTC (rev 28937)
+++ trunk/bibdesk/BibDesk.help/Contents/Resources/en.lproj/bibdesk.texi	2024-08-21 15:57:04 UTC (rev 28938)
@@ -182,7 +182,7 @@
 
 Portions of BibDesk:
 
-Copyright @copyright{} 2001 - 2023 Michael O. McCracken@*
+Copyright @copyright{} 2001 - 2024 Michael O. McCracken@*
 Copyright @copyright{} many others@*
 
 @c ======================================================================================

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Bibdesk-commit] SF.net SVN: bibdesk:[28937] tags/REL_1_9_5/

[<ho...@us...>]

Revision: 28937
          http://sourceforge.net/p/bibdesk/svn/28937
Author:   hofman
Date:     2024-08-19 09:24:11 +0000 (Mon, 19 Aug 2024)
Log Message:
-----------
Tag for release

Added Paths:
-----------
    tags/REL_1_9_5/

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Bibdesk-commit] SF.net SVN: bibdesk:[28936] trunk/bibdesk

[<ho...@us...>]

Revision: 28936
          http://sourceforge.net/p/bibdesk/svn/28936
Author:   hofman
Date:     2024-08-19 09:23:44 +0000 (Mon, 19 Aug 2024)
Log Message:
-----------
update version numbers for release

Modified Paths:
--------------
    trunk/bibdesk/BibDesk.help/Contents/Resources/en.lproj/version.texi
    trunk/bibdesk/Bibdesk.xcodeproj/project.pbxproj
    trunk/bibdesk/Info.plist

Modified: trunk/bibdesk/BibDesk.help/Contents/Resources/en.lproj/version.texi
===================================================================
--- trunk/bibdesk/BibDesk.help/Contents/Resources/en.lproj/version.texi	2024-08-18 16:25:19 UTC (rev 28935)
+++ trunk/bibdesk/BibDesk.help/Contents/Resources/en.lproj/version.texi	2024-08-19 09:23:44 UTC (rev 28936)
@@ -1 +1 @@
-@set VERSION 1.9.4
\ No newline at end of file
+@set VERSION 1.9.5
\ No newline at end of file

Modified: trunk/bibdesk/Bibdesk.xcodeproj/project.pbxproj
===================================================================
--- trunk/bibdesk/Bibdesk.xcodeproj/project.pbxproj	2024-08-18 16:25:19 UTC (rev 28935)
+++ trunk/bibdesk/Bibdesk.xcodeproj/project.pbxproj	2024-08-19 09:23:44 UTC (rev 28936)
@@ -6204,7 +6204,7 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = CE17EE7E0E24F27400DE06EA /* BibDesk-App.xcconfig */;
 			buildSettings = {
-				CURRENT_PROJECT_VERSION = 6114;
+				CURRENT_PROJECT_VERSION = 6115;
 				VERSIONING_SYSTEM = "apple-generic";
 			};
 			name = Debug;
@@ -6213,7 +6213,7 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = CE17EE7E0E24F27400DE06EA /* BibDesk-App.xcconfig */;
 			buildSettings = {
-				CURRENT_PROJECT_VERSION = 6114;
+				CURRENT_PROJECT_VERSION = 6115;
 				VERSIONING_SYSTEM = "apple-generic";
 			};
 			name = Release;

Modified: trunk/bibdesk/Info.plist
===================================================================
--- trunk/bibdesk/Info.plist	2024-08-18 16:25:19 UTC (rev 28935)
+++ trunk/bibdesk/Info.plist	2024-08-19 09:23:44 UTC (rev 28936)
@@ -303,7 +303,7 @@
 	<key>CFBundlePackageType</key>
 	<string>APPL</string>
 	<key>CFBundleShortVersionString</key>
-	<string>1.9.4</string>
+	<string>1.9.5</string>
 	<key>CFBundleSignature</key>
 	<string>BDSK</string>
 	<key>CFBundleURLTypes</key>

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Bibdesk-commit] SF.net SVN: bibdesk:[28935] trunk/bibdesk

[<ho...@us...>]

Revision: 28935
          http://sourceforge.net/p/bibdesk/svn/28935
Author:   hofman
Date:     2024-08-18 16:25:19 +0000 (Sun, 18 Aug 2024)
Log Message:
-----------
Don't check sharedPreviewer directly to see whether its window is visible, use class method that first checks whether the sharedPreviewer exists. So we don't need to create it early for safety.

Modified Paths:
--------------
    trunk/bibdesk/BDSKAppController.m
    trunk/bibdesk/BDSKPreviewer.h
    trunk/bibdesk/BDSKPreviewer.m
    trunk/bibdesk/BibDocument.m
    trunk/bibdesk/BibDocument_UI.m
    trunk/bibdesk/BibPref_TeX.m

Modified: trunk/bibdesk/BDSKAppController.m
===================================================================
--- trunk/bibdesk/BDSKAppController.m	2024-08-18 16:03:54 UTC (rev 28934)
+++ trunk/bibdesk/BDSKAppController.m	2024-08-18 16:25:19 UTC (rev 28935)
@@ -344,10 +344,6 @@
         [self showReadMeFile:nil];
     [[NSUserDefaults standardUserDefaults] setObject:versionString forKey:BDSKLastVersionLaunchedKey];
     
-    // Ensure the previewer and TeX task get created now in order to avoid a spurious "unable to copy helper file" warning when quit->document window closes->first call to [BDSKPreviewer sharedPreviewer]
-    if([[NSUserDefaults standardUserDefaults] boolForKey:BDSKUsesTeXKey])
-        [BDSKPreviewer sharedPreviewer];
-	
 	if([[NSUserDefaults standardUserDefaults] boolForKey:BDSKShowingPreviewKey])
 		[[BDSKPreviewer sharedPreviewer] showWindow:self];
     
@@ -464,7 +460,7 @@
 	if (act == @selector(toggleShowingPreviewPanel:)){ 
 		// menu item for toggling the preview panel
 		// set the on/off state according to the panel's visibility
-		if ([[BDSKPreviewer sharedPreviewer] isWindowVisible]) {
+		if ([BDSKPreviewer isSharedPreviewerVisible]) {
 			[menuItem setState:NSOnState];
 		}else {
 			[menuItem setState:NSOffState];

Modified: trunk/bibdesk/BDSKPreviewer.h
===================================================================
--- trunk/bibdesk/BDSKPreviewer.h	2024-08-18 16:03:54 UTC (rev 28934)
+++ trunk/bibdesk/BDSKPreviewer.h	2024-08-18 16:25:19 UTC (rev 28935)
@@ -75,6 +75,7 @@
 	@result Pointer to the single BDSKPreviewer instance.
 */
 @property (class, nonatomic, readonly) BDSKPreviewer *sharedPreviewer;
+@property (class, nonatomic, readonly, getter=isSharedPreviewerVisible) BOOL sharedPreviewerVisible;
 
 @property (nonatomic, retain) IBOutlet BDSKZoomablePDFView *pdfView;
 @property (nonatomic, strong) IBOutlet NSTextView *logView;

Modified: trunk/bibdesk/BDSKPreviewer.m
===================================================================
--- trunk/bibdesk/BDSKPreviewer.m	2024-08-18 16:03:54 UTC (rev 28934)
+++ trunk/bibdesk/BDSKPreviewer.m	2024-08-18 16:25:19 UTC (rev 28935)
@@ -104,6 +104,10 @@
 // Using isEqual:[BDSKSharedPreviewer sharedPreviewer] will lead to a leak if awakeFromNib is called while +sharedPreviewer is on the stack for the first time, since it calls isSharedPreviewer.  This is readily seen from the backtrace in http://sourceforge.net/tracker/index.php?func=detail&aid=1936951&group_id=61487&atid=497423 although it doesn't fix that problem.
 - (BOOL)isSharedPreviewer { return [self isEqual:sharedPreviewer]; }
 
++ (BOOL)isSharedPreviewerVisible {
+    return sharedPreviewer != nil && [sharedPreviewer isWindowVisible];
+}
+
 #pragma mark UI setup and display
 
 - (void)windowDidLoad{

Modified: trunk/bibdesk/BibDocument.m
===================================================================
--- trunk/bibdesk/BibDocument.m	2024-08-18 16:03:54 UTC (rev 28934)
+++ trunk/bibdesk/BibDocument.m	2024-08-18 16:25:19 UTC (rev 28935)
@@ -672,7 +672,7 @@
     
     // reset the previewer; don't send [self updatePreviews:] here, as the tableview will be gone by the time the queue posts the notification
     if ([[NSUserDefaults standardUserDefaults] boolForKey:BDSKUsesTeXKey]) {
-        if ([[BDSKPreviewer sharedPreviewer] isWindowVisible] &&
+        if ([BDSKPreviewer isSharedPreviewerVisible] &&
             [self isMainDocument] &&
             [self numberOfSelectedPubs] != 0)
             [[BDSKPreviewer sharedPreviewer] updateWithoutBibTeXString];

Modified: trunk/bibdesk/BibDocument_UI.m
===================================================================
--- trunk/bibdesk/BibDocument_UI.m	2024-08-18 16:03:54 UTC (rev 28934)
+++ trunk/bibdesk/BibDocument_UI.m	2024-08-18 16:25:19 UTC (rev 28935)
@@ -131,7 +131,7 @@
     [self updateSidePreviewPane];
     
     if([[NSUserDefaults standardUserDefaults] boolForKey:BDSKUsesTeXKey] &&
-	   [[BDSKPreviewer sharedPreviewer] isWindowVisible] &&
+	   [BDSKPreviewer isSharedPreviewerVisible] &&
        [self isMainDocument])
         [self updatePreviewer:[BDSKPreviewer sharedPreviewer]];
 }
@@ -1827,7 +1827,7 @@
             if ([previewer isVisible])
                 [self updatePreviews];
             else if ([[NSUserDefaults standardUserDefaults] boolForKey:BDSKUsesTeXKey] &&
-                    [[BDSKPreviewer sharedPreviewer] isWindowVisible] &&
+                    [BDSKPreviewer isSharedPreviewerVisible] &&
                     [self isMainDocument])
                 [self updatePreviewer:[BDSKPreviewer sharedPreviewer]];
         } else if ([key isEqualToString:BDSKUsesTeXKey]) {

Modified: trunk/bibdesk/BibPref_TeX.m
===================================================================
--- trunk/bibdesk/BibPref_TeX.m	2024-08-18 16:03:54 UTC (rev 28934)
+++ trunk/bibdesk/BibPref_TeX.m	2024-08-18 16:25:19 UTC (rev 28935)
@@ -192,7 +192,7 @@
             [alert setInformativeText:error];
             [alert beginSheetModalForWindow:[[self view] window] completionHandler:NULL];
         }
-    } else if ([key isEqualToString:BDSKUsesTeXKey] && [sud boolForKey:BDSKUsesTeXKey] == NO) {
+    } else if ([key isEqualToString:BDSKUsesTeXKey] && [sud boolForKey:BDSKUsesTeXKey] == NO && [BDSKPreviewer isSharedPreviewerVisible]) {
         // hide preview panel if necessary
         [[BDSKPreviewer sharedPreviewer] hideWindow:self];
     }

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Bibdesk-commit] SF.net SVN: bibdesk:[28934] trunk/bibdesk/SupportFile Revisions.plist

[<ho...@us...>]

Revision: 28934
          http://sourceforge.net/p/bibdesk/svn/28934
Author:   hofman
Date:     2024-08-18 16:03:54 +0000 (Sun, 18 Aug 2024)
Log Message:
-----------
remove hashes for non-existing revisions

Modified Paths:
--------------
    trunk/bibdesk/SupportFileRevisions.plist

Modified: trunk/bibdesk/SupportFileRevisions.plist
===================================================================
(Binary files differ)

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Bibdesk-commit] SF.net SVN: bibdesk:[28933] trunk/bibdesk/NSURL_BDS KExtensions.m

[<ho...@us...>]

Revision: 28933
          http://sourceforge.net/p/bibdesk/svn/28933
Author:   hofman
Date:     2024-08-18 14:49:33 +0000 (Sun, 18 Aug 2024)
Log Message:
-----------
remove unused variable

Modified Paths:
--------------
    trunk/bibdesk/NSURL_BDSKExtensions.m

Modified: trunk/bibdesk/NSURL_BDSKExtensions.m
===================================================================
--- trunk/bibdesk/NSURL_BDSKExtensions.m	2024-08-15 20:20:44 UTC (rev 28932)
+++ trunk/bibdesk/NSURL_BDSKExtensions.m	2024-08-18 14:49:33 UTC (rev 28933)
@@ -334,7 +334,6 @@
     CC_MD5_CTX md5context;
     NSUInteger signatureLength = CC_MD5_DIGEST_LENGTH;
     unsigned char signature[signatureLength];
-    unsigned char hexSignature[signatureLength * 2 + 1];
     NSUInteger blockSize = 4096;
     char buffer[blockSize];
     NSUInteger length = [data length];

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Bibdesk-commit] SF.net SVN: bibdesk:[28932] trunk/bibdesk/RelNotes. rtf

[<ho...@us...>]

Revision: 28932
          http://sourceforge.net/p/bibdesk/svn/28932
Author:   hofman
Date:     2024-08-15 20:20:44 +0000 (Thu, 15 Aug 2024)
Log Message:
-----------
update release notes

Modified Paths:
--------------
    trunk/bibdesk/RelNotes.rtf

Modified: trunk/bibdesk/RelNotes.rtf
===================================================================
(Binary files differ)

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Bibdesk-commit] SF.net SVN: bibdesk:[28931] trunk/bibdesk

[<ho...@us...>]

Revision: 28931
          http://sourceforge.net/p/bibdesk/svn/28931
Author:   hofman
Date:     2024-08-12 18:02:41 +0000 (Mon, 12 Aug 2024)
Log Message:
-----------
Replace files copied from SharedSupport to ApplicationSupport when they are an old revision. Check this by comparing the md5 hash of the current copied file with the hashes of old versions, which we register in a resource file. The SupportFileRevisions.plist file should be updated whenever a support file is changed.

Modified Paths:
--------------
    trunk/bibdesk/Bibdesk.xcodeproj/project.pbxproj
    trunk/bibdesk/NSFileManager_BDSKExtensions.m
    trunk/bibdesk/NSURL_BDSKExtensions.h
    trunk/bibdesk/NSURL_BDSKExtensions.m

Added Paths:
-----------
    trunk/bibdesk/SupportFileRevisions.plist

Modified: trunk/bibdesk/Bibdesk.xcodeproj/project.pbxproj
===================================================================
--- trunk/bibdesk/Bibdesk.xcodeproj/project.pbxproj	2024-08-09 22:07:30 UTC (rev 28930)
+++ trunk/bibdesk/Bibdesk.xcodeproj/project.pbxproj	2024-08-12 18:02:41 UTC (rev 28931)
@@ -473,6 +473,7 @@
 		CE4241450D0EAEFE00F824E7 /* BDSKEditorTextField.m in Sources */ = {isa = PBXBuildFile; fileRef = CE4241430D0EAEFE00F824E7 /* BDSKEditorTextField.m */; };
 		CE424A450D0F123500F824E7 /* BDSKCompletionServerProtocol.h in Headers */ = {isa = PBXBuildFile; fileRef = CE3A0BD50B1634D500233208 /* BDSKCompletionServerProtocol.h */; settings = {ATTRIBUTES = (Public, ); }; };
 		CE4385E90BB81D0500A56987 /* BDSKSearchBookmarkController.m in Sources */ = {isa = PBXBuildFile; fileRef = CE4385E70BB81D0500A56987 /* BDSKSearchBookmarkController.m */; };
+		CE43AF162C6A0E9600BA9FE5 /* SupportFileRevisions.plist in Resources */ = {isa = PBXBuildFile; fileRef = CE43AEF62C6A0E9600BA9FE5 /* SupportFileRevisions.plist */; };
 		CE4476DC2128907100DF38E1 /* DOMNode_BDSKExtensions.m in Sources */ = {isa = PBXBuildFile; fileRef = CE4476DA2128907100DF38E1 /* DOMNode_BDSKExtensions.m */; };
 		CE44BBA326370CB6008C7833 /* ComplexStringEditor.xib in Resources */ = {isa = PBXBuildFile; fileRef = CE44BBA226370CB6008C7833 /* ComplexStringEditor.xib */; };
 		CE44BBCE26371AFB008C7833 /* BDSKWebGroupView.xib in Resources */ = {isa = PBXBuildFile; fileRef = CE44BBCD26371AFB008C7833 /* BDSKWebGroupView.xib */; };
@@ -1560,6 +1561,7 @@
 		CE4241430D0EAEFE00F824E7 /* BDSKEditorTextField.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = BDSKEditorTextField.m; sourceTree = "<group>"; };
 		CE4385E60BB81D0500A56987 /* BDSKSearchBookmarkController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = BDSKSearchBookmarkController.h; sourceTree = "<group>"; };
 		CE4385E70BB81D0500A56987 /* BDSKSearchBookmarkController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = BDSKSearchBookmarkController.m; sourceTree = "<group>"; };
+		CE43AEF62C6A0E9600BA9FE5 /* SupportFileRevisions.plist */ = {isa = PBXFileReference; lastKnownFileType = file.bplist; path = SupportFileRevisions.plist; sourceTree = "<group>"; };
 		CE4476D92128907100DF38E1 /* DOMNode_BDSKExtensions.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = DOMNode_BDSKExtensions.h; sourceTree = "<group>"; };
 		CE4476DA2128907100DF38E1 /* DOMNode_BDSKExtensions.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = DOMNode_BDSKExtensions.m; sourceTree = "<group>"; };
 		CE44BBA226370CB6008C7833 /* ComplexStringEditor.xib */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = file.xib; path = ComplexStringEditor.xib; sourceTree = "<group>"; };
@@ -2523,6 +2525,7 @@
 				CE12A16F0B44AED100416D19 /* SearchGroupServers.plist */,
 				CE8962CA0CBEC10700EA2D98 /* TemplateOptions.plist */,
 				CE62DE4D0F4B790C00BDF01E /* Preferences.plist */,
+				CE43AEF62C6A0E9600BA9FE5 /* SupportFileRevisions.plist */,
 				CE18D6E321593FB60005CE3C /* Resources.r */,
 				F9BF481E0BD69F6F0071094F /* MODS2MARC21slim.xsl */,
 			);
@@ -4497,6 +4500,7 @@
 				CEB5D61A1072AE360001C135 /* BDSKSearchGroupView.xib in Resources */,
 				CEB0C6F026385D8700B63A29 /* BDSKCharacterConversion.strings in Resources */,
 				CEB5D61B1072AE360001C135 /* BDSKTypeInfoEditor.xib in Resources */,
+				CE43AF162C6A0E9600BA9FE5 /* SupportFileRevisions.plist in Resources */,
 				CEB5D61C1072AE360001C135 /* BDSKURLGroupSheet.xib in Resources */,
 				CEB5D61D1072AE360001C135 /* BDSKURLSheet.xib in Resources */,
 				CEB0C6E626385D8700B63A29 /* BDSKScriptGroupSheet.strings in Resources */,

Modified: trunk/bibdesk/NSFileManager_BDSKExtensions.m
===================================================================
--- trunk/bibdesk/NSFileManager_BDSKExtensions.m	2024-08-09 22:07:30 UTC (rev 28930)
+++ trunk/bibdesk/NSFileManager_BDSKExtensions.m	2024-08-12 18:02:41 UTC (rev 28931)
@@ -189,31 +189,45 @@
     return lyxPipeURL;
 }
 
-- (void)copyFileFromSharedSupportToApplicationSupport:(NSString *)fileName overwrite:(BOOL)overwrite{
-    NSURL *sourceURL = [[[NSBundle mainBundle] sharedSupportURL] URLByAppendingPathComponent:fileName isDirectory:NO];
+#define SUPPORT_FILE_REVISIONS_FILENAME @"SupportFileRevisions"
+
+- (void)copyRelativePath:(NSString *)fileName fromURL:(NSURL *)fromURL toURL:(NSURL *)toURL revisionHashes:(NSDictionary *)revisionHashes overwrite:(BOOL)overwrite{
+    NSURL *sourceURL = [fromURL URLByAppendingPathComponent:fileName isDirectory:NO];
     BOOL isDir = NO;
-    if ([self fileExistsAtPath:[sourceURL path] isDirectory:&isDir]) {
-        NSURL *targetURL = [[self applicationSupportDirectoryURL] URLByAppendingPathComponent:fileName isDirectory:isDir];
+    if ([self fileExistsAtPath:[sourceURL path] isDirectory:&isDir] == NO)
+        return;
+    NSURL *targetURL = [toURL URLByAppendingPathComponent:fileName isDirectory:isDir];
+    if (isDir) {
+        if ([self fileExistsAtPath:[targetURL path] isDirectory:&isDir] == NO) {
+            isDir = [self createDirectoryAtURL:targetURL withIntermediateDirectories:NO attributes:nil error:NULL];
+        } else if (isDir && overwrite == NO && revisionHashes == nil) {
+            revisionHashes = [NSDictionary dictionaryWithContentsOfURL:[[NSBundle mainBundle] URLForResource:SUPPORT_FILE_REVISIONS_FILENAME withExtension:@"plist"]];
+        }
         if (isDir) {
-            if ([self fileExistsAtPath:[targetURL path] isDirectory:&isDir] == NO)
-                isDir = [self createDirectoryAtURL:targetURL withIntermediateDirectories:NO attributes:nil error:NULL];
-            if (isDir) {
-                for (NSString *file in [self contentsOfDirectoryAtPath:[sourceURL path] error:NULL]) {
-                    if ([file hasPrefix:@"."] == NO)
-                        [self copyFileFromSharedSupportToApplicationSupport:[fileName stringByAppendingPathComponent:file] overwrite:overwrite];
-                }
+            for (NSString *file in [self contentsOfDirectoryAtPath:[sourceURL path] error:NULL]) {
+                if ([file hasPrefix:@"."] == NO)
+                    [self copyRelativePath:[fileName stringByAppendingPathComponent:file] fromURL:fromURL toURL:toURL revisionHashes:revisionHashes overwrite:overwrite];
             }
-        } else {
-            if ([targetURL checkResourceIsReachableAndReturnError:NULL]) {
-                if (overwrite == NO)
+        }
+    } else {
+        if ([targetURL checkResourceIsReachableAndReturnError:NULL]) {
+            if (overwrite == NO) {
+                if (revisionHashes == nil)
+                    revisionHashes = [NSDictionary dictionaryWithContentsOfURL:[[NSBundle mainBundle] URLForResource:SUPPORT_FILE_REVISIONS_FILENAME withExtension:@"plist"]];
+                NSArray *fileRevisionHashes = [revisionHashes objectForKey:fileName];
+                if ([fileRevisionHashes count] == 0 || [fileRevisionHashes containsObject:[targetURL md5Hash]] == NO)
                     return;
-                [self removeItemAtURL:targetURL error:NULL];
             }
-            [self copyItemAtURL:sourceURL toURL:targetURL error:NULL];
+            [self removeItemAtURL:targetURL error:NULL];
         }
+        [self copyItemAtURL:sourceURL toURL:targetURL error:NULL];
     }
 }
 
+- (void)copyFileFromSharedSupportToApplicationSupport:(NSString *)fileName overwrite:(BOOL)overwrite{
+    [self copyRelativePath:fileName fromURL:[[NSBundle mainBundle] sharedSupportURL] toURL:[self applicationSupportDirectoryURL] revisionHashes:nil overwrite:overwrite];
+}
+
 #pragma mark Temporary files and directories
 
 - (NSURL *)temporaryFileURLWithBasename:(NSString *)fileName {

Modified: trunk/bibdesk/NSURL_BDSKExtensions.h
===================================================================
--- trunk/bibdesk/NSURL_BDSKExtensions.h	2024-08-09 22:07:30 UTC (rev 28930)
+++ trunk/bibdesk/NSURL_BDSKExtensions.h	2024-08-12 18:02:41 UTC (rev 28931)
@@ -64,6 +64,8 @@
 @property (nonatomic, readonly) NSArray *openMetaTags;
 @property (nonatomic, readonly) double openMetaRating;
 
+@property (nonatomic, readonly) NSData *md5Hash;
+
 @property (nonatomic, readonly) NSAttributedString *linkedText;
 @property (nonatomic, readonly) NSAttributedString *linkedFileName;
 @property (nonatomic, readonly) NSAttributedString *icon;

Modified: trunk/bibdesk/NSURL_BDSKExtensions.m
===================================================================
--- trunk/bibdesk/NSURL_BDSKExtensions.m	2024-08-09 22:07:30 UTC (rev 28930)
+++ trunk/bibdesk/NSURL_BDSKExtensions.m	2024-08-12 18:02:41 UTC (rev 28931)
@@ -46,6 +46,7 @@
 #import <SkimNotesBase/SkimNotesBase.h>
 #import "NSFileManager_BDSKExtensions.h"
 #import "NSAttributedString_BDSKExtensions.h"
+#import <CommonCrypto/CommonDigest.h>
 
 #define OPEN_META_TAGS_KEY @"com.apple.metadata:kMDItemOMUserTags"
 #define OPEN_META_RATING_KEY @"com.apple.metadata:kMDItemStarRating"
@@ -328,6 +329,29 @@
     return [[[SKNExtendedAttributeManager sharedNoSplitManager] propertyListFromExtendedAttributeNamed:OPEN_META_RATING_KEY atPath:[self path] traverseLink:YES error:NULL] doubleValue];
 }
 
+- (NSData *)md5Hash {
+    NSData *data = [NSData dataWithContentsOfURL:self];
+    CC_MD5_CTX md5context;
+    NSUInteger signatureLength = CC_MD5_DIGEST_LENGTH;
+    unsigned char signature[signatureLength];
+    unsigned char hexSignature[signatureLength * 2 + 1];
+    NSUInteger blockSize = 4096;
+    char buffer[blockSize];
+    NSUInteger length = [data length];
+    NSRange range = NSMakeRange(0, MIN(blockSize, length));
+    
+    CC_MD5_Init(&md5context);
+    while (range.length > 0) {
+        [data getBytes:buffer range:range];
+        CC_MD5_Update(&md5context, (const void *)buffer, (CC_LONG)range.length);
+        range.location = NSMaxRange(range);
+        range.length = MIN(blockSize, length - range.location);
+    }
+    CC_MD5_Final(signature, &md5context);
+    
+    return [NSData dataWithBytes:signature length:signatureLength];
+}
+
 #pragma mark Templating
 
 - (NSAttributedString *)linkedText {

Added: trunk/bibdesk/SupportFileRevisions.plist
===================================================================
(Binary files differ)

Index: trunk/bibdesk/SupportFileRevisions.plist
===================================================================
--- trunk/bibdesk/SupportFileRevisions.plist	2024-08-09 22:07:30 UTC (rev 28930)
+++ trunk/bibdesk/SupportFileRevisions.plist	2024-08-12 18:02:41 UTC (rev 28931)

Property changes on: trunk/bibdesk/SupportFileRevisions.plist
___________________________________________________________________
Added: svn:mime-type
## -0,0 +1 ##
+application/octet-stream
\ No newline at end of property
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Bibdesk-commit] SF.net SVN: bibdesk:[28930] trunk/bibdesk/Templates/r tfdExportTemplate.rtfd/Bib Icon.pict

[<ho...@us...>]

Revision: 28930
          http://sourceforge.net/p/bibdesk/svn/28930
Author:   hofman
Date:     2024-08-09 22:07:30 +0000 (Fri, 09 Aug 2024)
Log Message:
-----------
Remove dummy icon from rtfd template

Removed Paths:
-------------
    trunk/bibdesk/Templates/rtfdExportTemplate.rtfd/Bib Icon.pict

Deleted: trunk/bibdesk/Templates/rtfdExportTemplate.rtfd/Bib Icon.pict
===================================================================
(Binary files differ)

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Bibdesk-commit] SF.net SVN: bibdesk:[28929] trunk/bibdesk/BDSKPubMedX MLParser.m

[<ho...@us...>]

Revision: 28929
          http://sourceforge.net/p/bibdesk/svn/28929
Author:   hofman
Date:     2024-07-30 18:10:36 +0000 (Tue, 30 Jul 2024)
Log Message:
-----------
Use ELocationID for Pages field when no Pagination is present from pubmed data

Modified Paths:
--------------
    trunk/bibdesk/BDSKPubMedXMLParser.m

Modified: trunk/bibdesk/BDSKPubMedXMLParser.m
===================================================================
--- trunk/bibdesk/BDSKPubMedXMLParser.m	2024-07-30 16:26:54 UTC (rev 28928)
+++ trunk/bibdesk/BDSKPubMedXMLParser.m	2024-07-30 18:10:36 UTC (rev 28929)
@@ -324,6 +324,9 @@
         addStringValueOfNodeForField([citation firstNodeForXPath:@"./Article/Pagination/MedlinePgn"], BDSKPagesString, pubFields);
         addStringValueOfNodeForField([citation firstNodeForXPath:@"./PMID"], @"Pmid", pubFields);
         
+        if ([pubFields objectForKey:BDSKPagesString] == nil)
+            addStringValueOfNodeForField([citation firstNodeForXPath:@"./Article/ELocationID[@EIdType='pii']"], BDSKPagesString, pubFields);
+        
         // not a BibTeX field: http://www.mail-archive.com/bib...@li.../msg04650.html
         addStringValueOfNodeForField([article firstNodeForXPath:@"./PubmedData/PublicationStatus"], @"Pst", pubFields);
         

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Bibdesk-commit] SF.net SVN: bibdesk:[28928] trunk/bibdesk/Templates/r tfPreviewTemplate.rtf

[<ho...@us...>]

Revision: 28928
          http://sourceforge.net/p/bibdesk/svn/28928
Author:   hofman
Date:     2024-07-30 16:26:54 +0000 (Tue, 30 Jul 2024)
Log Message:
-----------
fix typo in default preview template

Modified Paths:
--------------
    trunk/bibdesk/Templates/rtfPreviewTemplate.rtf

Modified: trunk/bibdesk/Templates/rtfPreviewTemplate.rtf
===================================================================
--- trunk/bibdesk/Templates/rtfPreviewTemplate.rtf	2024-07-05 15:42:27 UTC (rev 28927)
+++ trunk/bibdesk/Templates/rtfPreviewTemplate.rtf	2024-07-30 16:26:54 UTC (rev 28928)
@@ -123,7 +123,7 @@
 DOI: <$fields.Doi/>\
 </$fields.Doi?>\
 <$fields.Isbn?>\
-ISBN: <$fields.Isbni/>\
+ISBN: <$fields.Isbn/>\
 </$fields.Isbn?>\
 <$fields.Eprint?>\
 arXiv: <$fields.Eprint/>\

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Bibdesk-commit] SF.net SVN: bibdesk:[28927] trunk/bibdesk/BDSKMacroRe solver.m

[<ho...@us...>]

Revision: 28927
          http://sourceforge.net/p/bibdesk/svn/28927
Author:   hofman
Date:     2024-07-05 15:42:27 +0000 (Fri, 05 Jul 2024)
Log Message:
-----------
fix changing macro names, don't use valueForKey on maptable

Modified Paths:
--------------
    trunk/bibdesk/BDSKMacroResolver.m

Modified: trunk/bibdesk/BDSKMacroResolver.m
===================================================================
--- trunk/bibdesk/BDSKMacroResolver.m	2024-05-24 09:25:28 UTC (rev 28926)
+++ trunk/bibdesk/BDSKMacroResolver.m	2024-07-05 15:42:27 UTC (rev 28927)
@@ -210,7 +210,7 @@
         changeMacro:newMacro to:oldMacro];
     
     // retain in case these go away with removeObjectForKey:
-    NSString *val = [macroDefinitions valueForKey:oldMacro];
+    NSString *val = [macroDefinitions objectForKey:oldMacro];
     NSDictionary *userInfo = [NSDictionary dictionaryWithObjectsAndKeys:BDSKMacroResolverRenameType, BDSKMacroResolverTypeKey, oldMacro, BDSKMacroResolverOldMacroKey, newMacro,BDSKMacroResolverNewMacroKey, nil];
     
     [macroDefinitions removeObjectForKey:oldMacro];

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Bibdesk-commit] SF.net SVN: bibdesk:[28925] trunk/bibdesk/build_rel ease.py

[<ho...@us...>]

Revision: 28925
          http://sourceforge.net/p/bibdesk/svn/28925
Author:   hofman
Date:     2024-05-23 16:44:50 +0000 (Thu, 23 May 2024)
Log Message:
-----------
code sign dmg in build script

Modified Paths:
--------------
    trunk/bibdesk/build_release.py

Modified: trunk/bibdesk/build_release.py
===================================================================
--- trunk/bibdesk/build_release.py	2024-05-23 14:43:56 UTC (rev 28924)
+++ trunk/bibdesk/build_release.py	2024-05-23 16:44:50 UTC (rev 28925)
@@ -181,6 +181,17 @@
     print(f"codesign_bibdesk.sh exited with status {rc}")
     assert rc == 0, "code signing failed"
     
+def codesign_dmg(archive_path, identity):
+    
+    print("codesign %s" % (archive_path))
+    
+    sign_cmd = ["codesign", "-s", identity, "--timestamp", "-i", "edu.ucsd.cs.mmccrack.bibdesk.dmg", archive_path]
+    print(" ".join(sign_cmd))
+    x = Popen(sign_cmd, cwd=SOURCE_DIR)
+    rc = x.wait()
+    print(f"codesign dmg exited with status {rc}")
+    assert rc == 0, "code signing dmg failed"
+
 def notarize_archive(archive_path, password):
     
     notarize_cmd = ["xcrun", "notarytool", "submit", "--keychain-profile", password, "--wait", archive_path]
@@ -560,6 +571,8 @@
         archive_path = create_zip_of_application(new_version_string)
     else:
         archive_path = create_dmg_of_application(new_version_string, archive == "dmg")
+        if sign_id != "":
+            codesign_dmg(archive_path, sign_id)
     
     if notarize_password != "":
         # will bail if any part fails

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Bibdesk-commit] SF.net SVN: bibdesk:[28924] trunk/bibdesk/build_rel ease.py

[<ho...@us...>]

Revision: 28924
          http://sourceforge.net/p/bibdesk/svn/28924
Author:   hofman
Date:     2024-05-23 14:43:56 +0000 (Thu, 23 May 2024)
Log Message:
-----------
cleanup build script

Modified Paths:
--------------
    trunk/bibdesk/build_release.py

Modified: trunk/bibdesk/build_release.py
===================================================================
--- trunk/bibdesk/build_release.py	2024-05-23 13:31:19 UTC (rev 28923)
+++ trunk/bibdesk/build_release.py	2024-05-23 14:43:56 UTC (rev 28924)
@@ -21,7 +21,7 @@
 #   -a, --archive
 #      The type of archive the app bundle is wrapped in, the prepared disk image when empty
 #   -v, --version
-#      The new short version string ors +, ++, or +++, also bumps the version when this is passed
+#      The new short version string or +, ++, or +++, also bumps the version when this is passed
 #   -t, --test
 #      Prepare a test version, don't create appcast and release notes
 #
@@ -153,7 +153,7 @@
     assert newVersion is not None, "unable to read old version from Info.plist"
     assert newVersionString is not None, "unable to read old version from Info.plist"
     
-    return newVersion, newVersionString , minimumSystemVersion
+    return newVersion, newVersionString, minimumSystemVersion
 
 def clean_and_build():
     
@@ -488,7 +488,7 @@
         appcastString = newItemString
         appcastName = "bibdesk-" + newVersionString + ".xml"
     
-    appcastPath = os.path.join(outputPath , appcastName)
+    appcastPath = os.path.join(outputPath, appcastName)
     with open(appcastPath, "w", encoding="utf-8") as appcastFile:
         appcastFile.write(appcastString)
     
@@ -506,7 +506,7 @@
             readMe += "  *  " + item + "\n"
     
     # write the ReadMe file
-    readMePath = os.path.join(outputPath , "ReadMe-" + newVersionString + ".txt")
+    readMePath = os.path.join(outputPath, "ReadMe-" + newVersionString + ".txt")
     with open(readMePath, "w", encoding="utf-8") as readMeFile:
         readMeFile.write(readMe)
 

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Bibdesk-commit] SF.net SVN: bibdesk:[28923] trunk/bibdesk/build_rel ease.py

[<ho...@us...>]

Revision: 28923
          http://sourceforge.net/p/bibdesk/svn/28923
Author:   hofman
Date:     2024-05-23 13:31:19 +0000 (Thu, 23 May 2024)
Log Message:
-----------
use correct makedirs command in build script

Modified Paths:
--------------
    trunk/bibdesk/build_release.py

Modified: trunk/bibdesk/build_release.py
===================================================================
--- trunk/bibdesk/build_release.py	2024-05-20 21:21:11 UTC (rev 28922)
+++ trunk/bibdesk/build_release.py	2024-05-23 13:31:19 UTC (rev 28923)
@@ -587,7 +587,7 @@
     
     try:
         # probably already exists
-        os.mkdirs(out)
+        os.makedirs(out)
     except Exception as e:
         assert os.path.isdir(out), f"{out} does not exist"
     

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.