check_time(time, Date::RFC822) test fails
Brought to you by:
jart
make check-TESTS fails on amd64 arch with the following error:
make check-TESTS
make[2]: Entering directory `/var/tmp/portage/net-proxy/bfilter-1.1.3/work/bfilter-1.1.3/tests'
Running 31 test cases...
DateTestSuite.cpp(55): fatal error in "test": critical test check_time(time, Date::RFC822) failed
[1] OK: 145
[2] OK: 50
[3] OK: 70
[4] OK: 90
*** 1 failure detected in test suite "Master Test Suite"
FAIL: test
I've fixed this by applying attached patch. However, this patch is merely a workaround.
Logged In: YES
user_id=581631
Originator: NO
I think negative timestamps should be OK, unless they are below a certain value.
How about replacing:
if (time < 0)
with
if (time < low)
Will it pass then?