Various improvements combined:
- memory leak fixed (in p_tool.cpp)
- size_t instead of int for string length
- use of C++ instead of C headers
- LaTeX log file removed
Some additional improvements and code cleanups attached.
I integrated your patch by splitting it into several commits and specifying that you are the author.
Are you using a tool to detect unnecessary includes?
Thank you for your contribution.
Thanks for accepting the patch and sorry for sending all the changes as a single diff. I have modified the code before fetching bcomp's sources from SVN into a local GIT repository. Now making small commits is a lot easier for me.
I detected unnecessary includes by manual inspection while reading the code. I suspect that an automatic tool would be confused by the "RESOURCES/p_head.h" file, which includes almost all other headers.
The attached patch fixes yet another memory leak. This one was detected by cppcheck tool.
Another memory leak fixed and size_t/int typing improved.
Your patches have been integrated. Thanks again.
Log in to post a comment.