Re: [bbct-list] A few tweaks to the Eclipse projects in the git repository
Status: Beta
Brought to you by:
codeguru
|
From: Charanya A. <cha...@gm...> - 2013-07-30 00:30:51
|
I checked out your patches. I have these questions. 1) BaseballCardDetails: What are the import statements for? 2) Have you made changes to classpath files? I see it in diff, but I am not sure if you've made it. If you have made it, then the "classpathentry" element has path="C:/bbct-code/..". Is it ok to point it to C: ? or should the path be relative? Charanya On Mon, Jul 22, 2013 at 4:04 PM, Charanya Arvind <cha...@gm...>wrote: > Ok I will try them and let you know. > > > On Mon, Jul 22, 2013 at 2:01 PM, Code Guru <cod...@gm...> wrote: > >> After working with you on getting set up to work on this project, I made >> a few additions and changes to make it easier for future developers to join >> up. I have attached the related patches for your review. >> >> I know this is a small change, but I would like to get in the habit of >> reviewing each other's code before it is pushed to the main repo on >> sf.net. To apply these patches to your local repo, you should first >> checkout the devel branch and create a new branch. You can use "git apply" >> from the command line. Eclipse might have a way to do it as well, but I'm >> not as familiar with that. (In fact, I'm learning about patches as I write >> this.) >> >> Please let me know if you have any questions. >> >> Layne >> > > |