Re: [Bastille-linux-discuss] additions

[Peter W <pe...@us...>]

On Mon, Nov 26, 2001 at 04:14:52PM -0500, Niki Rahimi wrote:

> I forgot to add the following changes to other *.pm files. Note the changes
> in MiscellaneousDaemons.pm especially. These are major changes for SuSE.
> 
> (See attached file: apidiffspre3.txt)

Niki,

Would it make more sense to either overload the B_chkconfig_* functions
or require a second argument to the B_chkconfig_* functions?
 - Overload: if presented a second argument *and* on appropriate
   SuSE system, modify rc.config, changing the specified variable.
   [Perhaps complain/error out if on SuSE and not passed a second arg?]
 - Require a second argument every time. If on SuSE, modify that
   variable in rc.config
It just seems a little awkward having all that "if SuSE" code repeated
over and over again. With overloaded or redefined Bastille API functions,
the SuSE modifications would be smaller. 

-Peter