Re: [Basket-devel] how to drag a note?

[Martin S. <Ma...@li...>]

Hi again,

Am Samstag 05 Juni 2010 schrieb Martin Steigerwald:
> Am Freitag 04 Juni 2010 schrieb Dr. Robert Marmorstein:
> > Hi Martin,
> 
> Hi Robert!
> 
> > Both bugs are known.  The second bug has been fixed in my latest git
> > repository and will be in the 2.0 release.  The first bug
> > (drag-n-drop) is more difficult to solve.  I've been working on it
> > some this week, but it's stubborn.  It turns out that I may need to
> > completely redesign the BasketListView class to allow make dropping
> > work correctly.
> 
> Glad to hear that you fixedboth - see your other mail also - bugs .
> Thanks.
> 
> Can you point me out to how to get the exact patches that fix the drag
> and drop bug and insert inserts note with empty content bug? I think I
> could use git to extract those but I am not sure how.
> 
> I would like to point them out to the Debian maintainer and possibly
> help him with integrating the patches into the Debian package
> temporarily.
> 
> Or would it be even safe to use git trunk completely? Well might be
> better to take just these two bug fix patches. What do you think?

Robert, could you give me some enlightment regarding these questions 
above? I am not sure whether Basket 2.0 in August or possibly later comes 
in time for Debian Squeeze, thus I want to open two bug reports in Debian 
with some hints to patches or commit ids...

I found

commit 00c40e563a34d9f7ee623427861c9ce0e95196fa
Author: Dr. Robert Marmorstein <ro...@na...>
Date:   Fri May 21 19:28:06 2010 -0400

    Use a CopyJob instead of a FileCopyJob in drag.
    
    This fixes bug 232767 and possibly several other cut/copy/paste related
    problems.  FileCopyJob doesn't have a copyingDone signal, so it isn't
    possible to use it in the same was as an ordinary CopyJob.

in Kelvie git tree but I am not sure about the other fix. Is it in some git 
tree from you only?

Ciao,
-- 
Martin 'Helios' Steigerwald - http://www.Lichtvoll.de
GPG: 03B0 0D6C 0040 0710 4AFA  B82F 991B EAAC A599 84C7