#1 Check return codes everywhere

[Markus Elfring]

Some checks for return codes are missing.

Examples:
Would you like to add more error handling for return values from "malloc" like in the function "bartlby_check_sirene" and from "fwrite" in the function "bartlby_pre_init"?
http://bartlby.cvs.sourceforge.net/bartlby/bartlby-core/src/ack.c?revision=1.2&view=markup
http://bartlby.cvs.sourceforge.net/bartlby/bartlby-core/src/daemon.c?revision=1.11&view=markup

[Helmut Januschka]

Logged In: YES
user_id=1334896
Originator: NO

hello,
i have'nt seen your bug request, sorry for that
but both of your requestet changes have been done

regards

[Markus Elfring]

Logged In: YES
user_id=572001
Originator: YES

I suggest to avoid unchecked function calls.
Would you like to detect every error situation as early as possible?

http://bartlby.cvs.sourceforge.net/bartlby/bartlby-core/src/daemon.c?revision=1.12&view=markup
bartlby_pre_init: strdup(), chdir(), fclose()

http://bartlby.cvs.sourceforge.net/bartlby/bartlby-core/src/sched.c?revision=1.79&view=markup
schedule_loop: malloc()

Can the tool "http://splint.org/" help to find any remaining issues?

[Helmut Januschka]

Logged In: YES
user_id=1334896
Originator: NO

thanks for the hint, i already installed "splint" ill give it a try

regards

[Markus Elfring]

Logged In: YES
user_id=572001
Originator: YES

Would you like to reduce the efforts for error code checking by an exception class hierarchy?
http://dietmar-kuehl.de/mirror/c++-faq/exceptions.html#faq-17.1
http://cexcept.sourceforge.net/

[Markus Elfring]

Logged In: YES
user_id=572001
Originator: YES

It would be nice if more than a comment like "auto commit" will appear in the revision log.
Would you like to add a reference (case number) to this issue to the change log?

[Helmut Januschka]

Logged In: YES
user_id=1334896
Originator: NO

hello,

i am currently splint'ing and splint'ing
and yes i implemented a log message in my workflow in wich i file the SF ID

[SourceForge Robot]

Logged In: YES
user_id=1312539
Originator: NO

This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).

[Markus Elfring]

Logged In: YES
user_id=572001
Originator: YES

I guess that static source code analysis will point out more open issues.