Re: [Barry-devel] [patch] preliminary record refactoring patch
Status: Beta
Brought to you by:
ndprojects
From: Chris F. <cd...@fo...> - 2007-05-25 02:34:53
|
If my spidey sense is tingling correctly, I suspect you are refactoring to make a Record base class that all other record classes are derived from. I have purposely avoided doing this, since I want to make sure that all record classes are dead simple, and STL container safe. I've done large hierarchies of classes before, and making sure that the copy constructors and all the operator=3D() functions are correct is a bit of work, so I had intended to keep the record classes themselves hierarchy-less. The hierarchy I've done before had virtual operator=3D() functions, which is probably most of the reason why it was so much work (you could copy any object correctly, even through a base pointer). But I still favour simple record classes, just to make them absolutely bulletproof from the application's perspective. They should be able to toss these things around with no fear. This doesn't prevent us from making helper classes or helper functions, or even helper templates (although that's less than ideal, since that just hides the code duplication). All such helpers would be hidden inside the library, and not accessible to the application. I'll commit my file-split work soon, and hopefully you'll see what I mean. If you've done a lot of work on these already, I apologise for not speaking sooner. I see you're keen on sending patches (excellent!), so I'll try to post to the list more frequently as I work on things. From your previous emails, you have a bunch of record parsing classes waiting to send, and I haven't been working on any of that side lately, so we're at least not duplicating work there. Thanks, - Chris On Thu, May 24, 2007 at 10:21:53PM -0400, Chris Frey wrote: > Hi Brian, >=20 > I spent some time today splitting the records classes into separate files, > just haven't committed it yet. >=20 > Do you have a compile error that this patch fixes? It looks like it main= ly > changes the name from Record to RecordT. >=20 > - Chris >=20 >=20 > On Thu, May 24, 2007 at 07:14:23PM -0600, Brian Edginton wrote: > > Chris, > >=20 > > Could you please add this patch. It fixes some potential namespace col= lisions=20 > > in the templates in anticipation of refactoring the records classes. > >=20 > > Thanks, > > -edge > >=20 > > P.S. For anyone who cares and to save someone else work:I have Messages= , PIN=20 > > Messages and Saved Email Messages finished but I'll send the patches af= ter=20 > > the refactoring is finished. > >=20 >=20 >=20 > > -----------------------------------------------------------------------= -- > > This SF.net email is sponsored by DB2 Express > > Download DB2 Express C - the FREE version of DB2 express and take > > control of your XML. No limits. Just data. Click to get it now. > > http://sourceforge.net/powerbar/db2/ > > _______________________________________________ > > Barry-devel mailing list > > Bar...@li... > > https://lists.sourceforge.net/lists/listinfo/barry-devel >=20 >=20 > ------------------------------------------------------------------------- > This SF.net email is sponsored by DB2 Express > Download DB2 Express C - the FREE version of DB2 express and take > control of your XML. No limits. Just data. Click to get it now. > http://sourceforge.net/powerbar/db2/ > _______________________________________________ > Barry-devel mailing list > Bar...@li... > https://lists.sourceforge.net/lists/listinfo/barry-devel |