From: D. S. B. <bar...@fa...> - 2004-10-31 16:21:57
|
Hi, Thanks for your input. I've incorporated most of it into current CVS, except for the issue of the third party packages. Kern specifically wanted the parallel build structure so that there would be no possible confusion about what is or is not bacula for troubleshooting. I've changed the init scripts to remove the database service from sd and fd scripts. That change was suggested by another user right before 1.36.0 release and I didn't give it enough thought when I dropped it in. The configure script is filling in the db name so I've added a patch for building the sqlite packages that removes it from the dir script. I'm still thinking about the preinstall script error. Regards, Scott On Thu, 2004-10-28 at 22:36, Andreas Beckmann wrote: > Hi, > > I'm building RPMs for SuSE 9.1 x86_64 using sqlite as database backend for bacula and found a few issues in 1.36.0 (from 1.36.0-1 SRPM). I'm adding patches I created to fix these problems. > > > *** BuildRequires: libgnome [bacula.spec-buildreq-libgnome.patch] > > This is needed for a successful build of the gnome-console. > libgnome is not a dependency of the libgnome-devel (or other) package, > so it was missing on the headless machine I used for the build. > > > *** traces left over in /usr/src/packages/BUILD > [bacula.spec-extra-sources.patch] > > After building the RPMs there are traces left over in > /usr/src/packages/BUILD that can't be cleaned automatically: > depkgs, tomsrtbt, Release_Notes > I fixed this by > * extracting the bacula source only once (this was done three times) > * extracting and building the extra sources (depkgs, tomsrtbt, ...) > below the bacula source tree (not parallel to the bacula tree) > * using a unified method to access depkgs (was mixture of '%{depkgs}' > and '../depkgs') > > > *** init.d/bacula-{fd,sd} depend on database service > [bacula-01-suse-initscripts.patch] > > IIRC only the director talks to the database, so storage daemon and file daemon don't need any database running at all. Especially the client package shouldn't require any database. > > > *** init.d/bacula-dir requires running service sqlite [no patch] > > But sqlite has been statically included, so there is no need for a running service at all nor is there anything providing such a service. > > > *** preinstall script - error messages [no patch] > > If /var/bacula/bacula.db exists, but /usr/lib/sqlite/sqlite doesn't exist (e.g. because some version of bacula-sqlite.rpm had been installed at some time, but had been removed in the mean time) the preinstall script throws an error message: > /var/tmp/rpm-tmp.82689: line 1: /usr/lib/sqlite/sqlite: > No such file or directory > The error message is just a cosmetic issue, but perhaps the missed db version test could cause problems? > > > > If you find this useful, you could incorporate it in a future release. > > > Andreas |