Re: [Bacula-devel] Patch: Add option to disable RunScript functionality in Bacula File Daemon.

[Kern S. <ke...@si...>]

Hello Arkadiusz,

These are nice ideas, and I will certainly accept your patch, but there are
a few items to work out:

1. Please go to www.bacula.org and click on the FLA License in the left
     menu, print it, fill it out, sign it, and send it to me.  This 
permits Bacula
     and myself to use the code you submit.

2. Please read our Developer's guide that gives you an idea how we 
indent and
     use braces {} in expressions.  This is not a critical item, but we 
are very
     determined to keep the code in a uniform style, so it helps if you 
submit
     with the correct style.

3. For backward compatibility, we will need to make sure the default 
behavior
     of the FD is the same as before rather than the new behavior that 
you have
     defined.  This is important.

4. I would probably call your new directive: Allow RunScripts, and it 
would by
     default be turned on.  As with item 2, this is a minor point that 
is easy for
     us to correct in integrating it, but can help you for this and 
future contributions.

I am waiting to receive the FLA,

Best regards,
Kern

On 08/12/2013 09:38 AM, Arkadiusz Bubała wrote:
> Hello,
> we've prepared patch to add option to disable RunScript functionality 
> in Bacula File Daemon. The goal was that the user can't execute script 
> on the client side for the security reasons. New configuration option 
> has been called "AllowScripts" and if it is set to "yes" Bacula File 
> Daemon is able to execute scripts.  By default this option is set to 
> "no" so when the user tries to execute script he'll get an error: 
> "2999 Bad Executing scripts is not allowed".
>
> We have also other idea of giving configurable restrictions in Bacula 
> client for backup and restore. We would like to give opportunity of 
> configure what directories will be accessible by server for making 
> backup from. This can be achieved by adding option in Bacula client 
> configuration file that will store regular expression describing what 
> paths can be backed up. We would like to add this configuration option 
> also for restore. To let restore backups only in certain paths 
> described by regular expressions. Those changes are very useful in our 
> environment where we would like to integrate Bacula client. We won't 
> let backup internal system files, only user data can be backed up. 
> Also restore should be possible only in space separated for user. We 
> also think that this changes are useful for any Bacula user because it 
> is possible to restrict access to certain files on client machine and 
> don't allow restore to places where it shouldn't be done. For example 
> user can restrict restore only to specified path and make sure that 
> some system files won't be changed during restore.
>
>
>
> ------------------------------------------------------------------------------
> Get 100% visibility into Java/.NET code with AppDynamics Lite!
> It's a free troubleshooting tool designed for production.
> Get down to code-level detail for bottlenecks, with <2% overhead.
> Download for free and get started troubleshooting in minutes.
> http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
>
>
> _______________________________________________
> Bacula-devel mailing list
> Bac...@li...
> https://lists.sourceforge.net/lists/listinfo/bacula-devel