Re: [Bacula-devel] [PATCH] Implement systemd socket activation support for filed

[Dan L. <da...@la...>]

On Apr 30, 2011, at 3:00 PM, Michael Stapelberg wrote:

> Hi,
> 
> I just implemented systemd socket activation support in bacula-fd. Quote from
> the commit message:

How does this affect systems which do not implement systemd?

>    This commit implements socket activation support. Instead of starting the filed
>    and having it waiting for connections, you can let systemd listen on port 9102
>    and start bacula-fd when it’s actually necessary (as soon as the first client
>    connects). This further speeds up system boot and lowers resource consumption for
>    sessions in which bacula-fd is not actually used.
> 
> There is one little problem in the code, though (flagged as XXX):
> in src/lib/bnet_server.c, when creating a new bsock object for a connection,
> the port to which the client connected is stored. When using systemd socket
> activation, we don’t have this information (maybe we can get it from the
> listening socket, though).
> 
> As I did not find any uses of the ->port() property in the filed code, I
> decided to just hard-code it to 9102 for now. Can anyone who is more familiar
> with the networking code in bacula please explain if and why setting the port
> property is necessary?

-- 
Dan Langille - http://langille.org