[Bacula-bugs] [bacula 0001713]: StorageACL does not work on "status storage" (bconsole sees all storage devices despite limit)

[Mantis B. T. <no...@bu...>]

The following issue has been UPDATED. 
====================================================================== 
http://bugs.bacula.org/view.php?id=1713 
====================================================================== 
Reported By:                mnalis
Assigned To:                
====================================================================== 
Project:                    bacula
Issue ID:                   1713
Category:                   Director
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     acknowledged
====================================================================== 
Date Submitted:             2011-03-22 15:51 GMT
Last Modified:              2011-03-23 15:26 GMT
====================================================================== 
Summary:                    StorageACL does not work on "status storage"
(bconsole sees all storage devices despite limit)
Description: 
StorageACL limiting does not work for "status storage" or ".status storage"
commands, instead it allows users to see status of all devices on all that
Storage Daemon.

Steps to Reproduce: 
Have one bacula-sd with multiple file storage devices, and appropriate multiple
director Storage sections (one for each device).

Director also have Console section with StorageACL limiting access to only one
of the storages. 

Have bconsole connect to director using that Console, and issue "status storage"
command. It will show ALL file storage devices, instead of just one allowed via
StorageACL.

Other commands seem to work correctly (for example, you can only choose allowed
storage in run job command etc)

Additional Information: 
exact bacula version is 5.0.3 with git Branch-5.0 as of 20110301

====================================================================== 

---------------------------------------------------------------------- 
 (0005808) marcovw (developer) - 2011-03-23 15:17
 http://bugs.bacula.org/view.php?id=1713#c5808 
---------------------------------------------------------------------- 
Ok I see the problem and think we have it for client acls too. Will see if I can
come up with an patch for you to test. 

---------------------------------------------------------------------- 
 (0005809) marcovw (developer) - 2011-03-23 15:26
 http://bugs.bacula.org/view.php?id=1713#c5809 
---------------------------------------------------------------------- 
Attached patch should fix the problem for not checking acls on clients and
storage for both .status and status cmds. Let me know if it applies and works
then I can push it to the proper releases. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-03-22 15:51 mnalis         New Issue                                    
2011-03-22 15:51 mnalis         Issue Monitored: mnalis                      
2011-03-23 15:17 marcovw        Note Added: 0005808                          
2011-03-23 15:17 marcovw        Status                   new => acknowledged 
2011-03-23 15:25 marcovw        File Added: bug1713.patch                    
2011-03-23 15:26 marcovw        Note Added: 0005809                          
======================================================================