From: Mantis B. T. <no...@bu...> - 2010-11-19 17:37:12
|
A NOTE has been added to this issue. ====================================================================== http://bugs.bacula.org/view.php?id=1656 ====================================================================== Reported By: phil Assigned To: ====================================================================== Project: bacula Issue ID: 1656 Category: start/stop scripts Reproducibility: always Severity: feature Priority: normal Status: feedback ====================================================================== Date Submitted: 2010-10-29 19:29 UTC Last Modified: 2010-11-19 17:37 UTC ====================================================================== Summary: Add check so that bacula-ctl-dir , etc do not crash if invalid config file Description: patch included to add checks to the "restart" option of these. ====================================================================== ---------------------------------------------------------------------- (0005660) ebollengier (administrator) - 2010-11-19 15:01 http://bugs.bacula.org/view.php?id=1656#c5660 ---------------------------------------------------------------------- Could you be more explicit on what you want to do, and what you patch is supposed to do? If your idea is to check the configuration file before issuing the restart command, it can be a nice addition, but your patch doesn't to do that. ---------------------------------------------------------------------- (0005662) phil (reporter) - 2010-11-19 17:22 http://bugs.bacula.org/view.php?id=1656#c5662 ---------------------------------------------------------------------- It doesnt? Yes, my intent is, "1. Check the file for errors. 2. Do not continue, if errors are present" I guess you're saying it needs to be changed from ${BACDIRBIN}/bacula-dir -t to ${BACDIRBIN}/bacula-dir -t || exit 1 ? ---------------------------------------------------------------------- (0005663) ebollengier (administrator) - 2010-11-19 17:35 http://bugs.bacula.org/view.php?id=1656#c5663 ---------------------------------------------------------------------- Why not, but I'm pretty sure that LSD startup scripts doesn't allow this kind of output or exit code. You need also to use the right user/group for the test command (else it can create files with root:root instead of bacula:bacula), specify the configuration file, use the appropriate error message and exit code. I'm not a LSB script specialist, so you will probably need to start a thread on the bacula-devel list to get advise from other users. Bye ---------------------------------------------------------------------- (0005664) phil (reporter) - 2010-11-19 17:37 http://bugs.bacula.org/view.php?id=1656#c5664 ---------------------------------------------------------------------- Well, seeing as how my primary platform is solaris, and I WANT to see that sort of output, I dont care about doing that :) Issue History Date Modified Username Field Change ====================================================================== 2010-10-29 19:29 phil New Issue 2010-10-29 19:29 phil File Added: bacula.patch 2010-11-05 12:25 mnalis Issue Monitored: mnalis 2010-11-19 15:01 ebollengier Note Added: 0005660 2010-11-19 15:02 ebollengier Severity major => feature 2010-11-19 15:02 ebollengier Status new => feedback 2010-11-19 17:22 phil Note Added: 0005662 2010-11-19 17:35 ebollengier Note Added: 0005663 2010-11-19 17:37 phil Note Added: 0005664 ====================================================================== |