Re: [Bacula-devel] unmount mounted DVD volume

[Richard M. <ri...@ol...>]

Hi Kern,

Patch attached that fixes the problem below. I have rebased
the patch against CVS HEAD and have tested as much as I can.
I've made a few tweaks over and above the original patch that
I sent out - specifically it now fails (with a sensible error
message) if it is unable to unmount the DVD filesystem due
to someone accessing a file etc.

Richard

> -----Original Message-----
> From: bac...@li... 
> [mailto:bac...@li...] On Behalf 
> Of Richard Mortimer
> Sent: 21 July 2006 23:53
> To: bac...@li...
> Subject: Re: [Bacula-devel] unmount mounted DVD volume (was 
> Re: DVDvolume labels)
> 
> On Tue, 2006-06-27 at 00:16 +0100, Richard Mortimer wrote:
> > On Mon, 2006-06-26 at 20:42 +0200, Kern Sibbald wrote:
> > > Oh, that would be really nice if it works.  I had almost 
> given up on DVD 
> > > writing.  Thanks for the quick feedback, and I look 
> forward to hearing the 
> > > results of your more extensive testing.
> > > 
> > 
> > 6) bconsole unmount the DVD mounted in (5). This claims 
> that the disk is
> > "already unmounted" and leaves the disk mounted in 'df'
> > 
> > *umount
> > ...
> > 3901 Device "DVDStorage" (/dev/cdrw) is already unmounted.
> > 
> > storage daemon output below. Note that a subsequent backup and/or
> > restore will unmount the device (also using shell umount).
> 
> Ok, I finally found some time to look into this. It seems that unmount
> just isn't implemented for DVD. I have attached a patch that does a
> first pass at implementing it. It works for me and 
> successfully handles
> the cases where a manual mount/umount has been done outside of bacula.
> 
> Notes/issues to resolve
> 
> 1 - I am not sure if I have all of the cases in unmount implemented
> correctly. I would appreciate any feedback as to the correct way to
> handle things and whether any of the original tape/automounter calls
> are needed for dvd
> 
> 2 - I had to change the fnmatch call for "is already mounted" 
> to make it
> match the mount output (for Debian/Sarge just in case other versions
> have different messages). I also added a similar match for unmount to
> handle already unmounted.
> 
> 3 - The main issue that I know if is that if the /sbin/umount command
> is not able to unmount (due to a file being open on the 
> filesystem) then
> the bacula unmount command returns "unmounted ok". I'll look into the
> required changes for that soon.
> 
> Regards
> 
> Richard
> 
> -- 
> Richard Mortimer <ri...@ol...>
>