Re: [Bacula-devel] growisofs patch for dvd+rw-tools v6.1

[Nicolas B. <ni...@bo...>]

Hi again,

I just ran it, and found a little mistake causing a segfault when
running with -F.

The attached patch should be ok.

Best regards,

Nicolas

On Tue, 2006-02-14 at 23:32 +0100, Nicolas Boichat wrote:
> Hi Michel, Hi Arno,
> 
> I looked at this quickly, and only really small modifications were
> needed to apply the patch (there was nothing more than an offset
> problem). I attached the new patch. Please note I did not test it, so it
> would be nice if you could do so.
> 
> I'll send it upstream and see how the maintainer reacts.
> 
> Best regards,
> 
> Nicolas
> 
> On Mon, 2006-02-06 at 16:44 +0100, Michel Meyers wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> > 
> > Hello,
> > 
> > I just noticed that Debian got a new release (6.1) of dvd+rw-tools in
> > testing (and unstable). The growisofs.c patch doesn't seem to apply
> > properly to it.
> > 
> > I get:
> > 
> > patch < dvd+rw-tools-5.21.4.10.8.bacula.patch
> > patching file growisofs.c
> > Hunk #1 FAILED at 315.
> > Hunk #2 succeeded at 2334 (offset 609 lines).
> > Hunk #3 FAILED at 2534.
> > Hunk #4 succeeded at 2584 (offset 633 lines).
> > Hunk #5 succeeded at 2627 (offset 634 lines).
> > Hunk #6 succeeded at 2899 (offset 766 lines).
> > 2 out of 6 hunks FAILED -- saving rejects to file growisofs.c.rej
> > 
> > The first one is obviously the version line that doesn't correspond.
> > It's the second one (#3) that worries me. Is there an updated version of
> > the patch yet? (I'd try to fix this myself but my programming
> > skills/knowledge are barely enough to hack together some dumb PHP and
> > shell scripts.)
> > 
> > While I am at it, are there any plans to get the '-F' functionality
> > integreated into upstream (thus eliminating the need to manually patch
> > growisofs)?
> > 
> > Greetings,
> >          Michel
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v1.4.2 (MingW32) - GPGrelay v0.959
> > 
> > iD8DBQFD527t2Vs+MkscAyURAmlxAKCwHmlb0cGROHwMYh/HgntN3JD/MwCfVtli
> > o5R9Oqu+B2YM0pA0OKvSid0=
> > =FVLf
> > -----END PGP SIGNATURE-----
> > 
> > 
> > -------------------------------------------------------
> > This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
> > for problems?  Stop!  Download the new AJAX search engine that makes
> > searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
> > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
> > _______________________________________________
> > Bacula-devel mailing list
> > Bac...@li...
> > https://lists.sourceforge.net/lists/listinfo/bacula-devel
> >