Re: [Bacnet-developers] [Update] Activating BVLC code

[<to...@tu...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thu, Jan 17, 2008 at 05:25:18PM -0600, Steve Karg wrote:
> Hello Tomás,
> 
> > OK, here they are. I attached them
> 
> Got the patches and applied most of them, and made a couple of
> changes.  The changes are in subversion.
> 
> >   0002-Fix-endianness-glitch-in-ip-addr-and-port.patch
> >       bip_get_xxx() seem to deliver address and port in host order. Use
> >       decode_unsigned_xxx to marshal them into PDU
> 
> I prefer to use htonl() and htons() for these network address changes.
>  I made the changes in the file.

Yes, of course. That makes more sense.

[...]

> Let me know if that code works for you with the changes that I made,
> as I have only compiled but not tested it.

I'll test today.

> Also, regarding BBMD_ENABLED, were you using that in your
> applications?  I didn't see any changes in any of the other source
> files for it.

I changed it in each of the Makefiles...

I think yes: the client app ("us") was talking to a server ("them") in a
different IP subnet, both connected through two BBMDs. "Readprop" worked,
fine, and as checked with tcpdump/wireshark:

  - We sent the "whohas" to do the object resolution as a local UDP
    broadcast;

  - The answer came back as a BVLC forwarded PDU, with the original MAC
    in the BVLC header (thus I assume that "or" BBMD picked up our
    broadcast and forwarded it to the other subnet, "their" answer was
    picked up there and forwarded to "us" -- but I can't see this part).

  - We then sent the "read property" request directly to "them" and
    received the answer, both as UDP unicasts.

>                I also put it into config.h instead of the Makefile,
> and made it into a boolean (rather than just a define).

(slaps forehead) Yes, this makes more sense, instead of munging loads of
Makefiles :-)

> Thanks again for your contribution!

Thanks for your kind support

Regards
- -- tomás
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFHkDpSBcgs9XrR2kYRAo81AJ9Mb/v0/6LQdvCbO8kIIZE3ZzZ3ZQCggYu3
zNeFAge6OolGZa0glZ/gdB4=
=zNgF
-----END PGP SIGNATURE-----