Re: [Bacnet-developers] [Update] Activating BVLC code

[Steve K. <st...@ka...>]

Hello Tom=E1s,

> OK, here they are. I attached them

Got the patches and applied most of them, and made a couple of
changes.  The changes are in subversion.

>   0002-Fix-endianness-glitch-in-ip-addr-and-port.patch
>       bip_get_xxx() seem to deliver address and port in host order. Use
>       decode_unsigned_xxx to marshal them into PDU

I prefer to use htonl() and htons() for these network address changes.
 I made the changes in the file.

> Let me know whether I got the patch format right this time :-)

All patches worked fine using:
$ patch -p1 < name.patch

Let me know if that code works for you with the changes that I made,
as I have only compiled but not tested it.

Also, regarding BBMD_ENABLED, were you using that in your
applications?  I didn't see any changes in any of the other source
files for it.  I also put it into config.h instead of the Makefile,
and made it into a boolean (rather than just a define).

Thanks again for your contribution!

Best Regards,

Steve
--=20
http://steve.kargs.net/