Re: [Bacnet-developers] [Update] Activating BVLC code
Brought to you by:
skarg
|
From: Steve K. <st...@ka...> - 2008-01-14 15:32:52
|
Hello Tom=E1s, > Did I understand correctly that you prefer the shorter variants? Shall I > change _DISTRIBUTION_ to _DIST_ consistently -- or only in cases where > the identifier is longer than 31 chars? MISRA-C Rule 11 says: Identifiers (internal and external) shall not rely on significance of more than 31 characters. Furthermore, the compiler/linker shall be checked to ensure that 31 character significance and case sensitivity are supported for external identifiers. I would prefer to only make changes in cases where the identifier is longer than 31 characters and the first 31 characters are identical. I prefer descriptive (longer) variants (as one can see from the code), but compilers and standards and screen sizes can be limiting. :-) Most of the enumerations match exactly the name given in the BACnet standard since I did a lot of copy-paste from the standard when creating them. The only difference is usually the prefix name. Best Regards, Steve --=20 http://steve.kargs.net/ |