Re: [Bacnet-developers] [Update] Activating BVLC code

[Steve K. <st...@ka...>]

Hello Tomas,

> > call me crazy, but I'm giving a try at the (as far as I can see not yet
> > fully functional) BVLC code [...]

You are crazy - Not! Thank you for the hard work and working to finish
the code that I started.

> Whois works now with "forwarded broadcast" answers. Wohoo! :-)

Outstanding!

> The only issue I found was in bvlc.c. The BVLC header is a bit longer
> for this kind of messages (10 bytes instead of four, to accomodate the
> original MAC address). Note that I haven't a version of Annex J, so I'm
> working off what Wireshark tells me.

Annex J is given in its entirety on http://www.bacnet.org/ as:
Addendum 135-1995a

   1. Add Annex J - BACnet/IP and supporting definitions

http://www.bacnet.org/Addenda/Add-1995-135a.pdf

> All in all I'm impressed by your code quality. For a part of the code which
> is not really supposed to be ready, it is really near to working status.

Thank you for the kind comments.  I will apply your patches when you are ready.

As far as the changes to include/bacenum.h, I started compiling with
Borland Turbo C+ 1.0 for DOS, as well as working towards some MISRA-C
compliance.  Both prefer unique enumerations up to 31 characters,
which is why BVLC_READ_BROADCAST_DIST_TABLE is shorter.  I apparently
didn't follow up and change the code that used that particular
enumeration.

Best Regards,

Steve
-- 
http://steve.kargs.net/