Re: [BackupPC-users] smbclient tar problem with umlauts

[Oliver F. <Oli...@io...>]

Hello,

here's the patch to make smbclient 4.2.10 work with backuppc:

diff -u Backuppc3.2.1/lib/BackupPC/Xfer/Smb.pm 
BackupPC3/lib/BackupPC/Xfer/Smb.pm
--- Backuppc3.2.1/lib/BackupPC/Xfer/Smb.pm      2012-11-09 
18:37:14.000000000 +0100
+++ BackupPC3/lib/BackupPC/Xfer/Smb.pm  2016-07-01 13:56:10.162250854 +0200
@@ -230,7 +230,9 @@
              $t->{byteCnt} += $2;
              $t->{fileCnt}++;
              $t->{XferLOG}->write(\"$_\n") if ( $t->{logLevel} >= 1 );
-        } elsif ( /^\s*tar: dumped \d+ files/ ) {
+        } elsif ( /^\s*tar: dumped \d+ files/
+                 || /Total bytes received: \d+/i
+        ) {
              $t->{xferOK} = 1;
              $t->{XferLOG}->write(\"$_\n") if ( $t->{logLevel} >= 0 );
          } elsif ( /^\s*tar: restored \d+ files/ ) {
@@ -239,7 +241,7 @@
          } elsif ( /^\s*read_socket_with_timeout: timeout read. /i ) {
              $t->{hostAbort} = 1;
              $t->{XferLOG}->write(\"$_\n") if ( $t->{logLevel} >= 0 );
-        } elsif ( /^code 0 listing /
+        } elsif ( /^code 0 listing /
                      || /^\s*code 0 opening /
                      || /^\s*abandoning restore/i
                      || /^\s*Error: Looping in FIND_NEXT/i
@@ -270,6 +272,7 @@
          } elsif ( /^\s*directory \\/i ) {
              $t->{XferLOG}->write(\"$_\n") if ( $t->{logLevel} >= 2 );
          } elsif ( /smb: \\>/
+                || /^\s*tar:\d+/
                  || /^\s*added interface/i
                  || /^\s*tarmode is now/i
                  || /^\s*Total bytes written/i

As you see The first chunk accept the message "total bytes received"
as success, the last chunk ignores the other messages that start with 
"tar:linenumber".

Sadly smbclient does no more send the number of files transmitted, so
one has to put
$Conf{BackupZeroFilesIsFatal} = 0;
into the config and live without this check.

That's it for now,

Oliver


Am 02.07.2016 um 18:08 schrieb megaram:
> Could you please link how to patch the smb.pm ?
>
> +----------------------------------------------------------------------
> |This was sent by ma...@me... via Backup Central.
> |Forward SPAM to ab...@ba....
> +----------------------------------------------------------------------
>
>
>
> ------------------------------------------------------------------------------
> Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
> Francisco, CA to explore cutting-edge tech and listen to tech luminaries
> present their vision of the future. This family event has something for
> everyone, including kids. Get more information and register today.
> http://sdm.link/attshape
> _______________________________________________
> BackupPC-users mailing list
> Bac...@li...
> List:    https://lists.sourceforge.net/lists/listinfo/backuppc-users
> Wiki:    http://backuppc.wiki.sourceforge.net
> Project: http://backuppc.sourceforge.net/
>