Re: [Babeldoc-devel] Scanners and filters...

[David K. <dav...@al...>]

Dejan, Mike, list,

Dejan Krsmanovic wrote:

> Hi Mike,
[snip]
> Anyway, I have just copied methods from 1.0 branch to current (1.2). I have
> no time for testing now so please check if there are some problems with it!
> Try to add filtering functionality to MailbxScanner with this config.

I have tested the methods in my setup and they seem to work just
fine. Filtering works, both with and without a specified filter.
What's nicer is that I was able to drop my own filtering stuff,
since these methods cover the needs I have.

I did some trivial cleanup:

- Added missing messages to messages.properties (please review!)
- Moved the patterns Hashtable to the top of the ScannerWorker
  file and added a brief javadoc about it
- Re-ordered the methods and accompanying javadocs that got a
  bit mixed up (addFilter and acceptEntry) and added a bit more
  javadoc text explaining how the filter logic works
- Really "new" in this patch is only my previously suggested
  addition of providing the DirectoryScanner's doneDirectory
  under the attribute "done_dir"

Patch, as described above, attached.

> Thanks,
> Dejan

/David