Re: [Babeldoc-devel] Scanner filtering patch

[David K. <dav...@al...>]

Dejan Krsmanovic wrote:
> Hi David, 

Hi Dejan!

> I have just realized that filtering is not implemented
> in new scanner version. It was implemented in 1.0
> release but since I have rewrote whole scanner for 1.1
> I obivioulsy forgot to implement it.
> Have you checked if your code looks like code in 1.0? 

I'm afraid not. I had no clue this was present earlier, so
I just went ahead and did it. Wasn't much code, anyway...

> I  will review your code as soon as possible. And
> don't worry, mine implementation has also required 1.4
> since it used java.util.regex package. There are some
> other pieces of Babeldoc that require it...

Ok, that's good to know for future work.

> Dejan
> P.S. Are you sure you don't want to become commiter?

Heh, yeah, for the time being. But don't close the door.

(You fixed the filename problem in the scanner, I see. Good,
 then I can scrap my own fix that I just did for it. :-)  )

Regards,

David