|
From: Bruce M. <br...@mc...> - 2003-07-16 02:46:20
|
Jonathan. Excellent. Both of these sound GREAT! I especially like the weakhashmap - this really solves this problem elegantly. Please commit. Regards, Bruce. On Tuesday 15 July 2003 07:42 pm, Leech, Jonathan wrote: > I've got a couple of things I want to do to DomifyPipelineStage... > 1) The first is the DTD cache I mentioned before. I would like to use a > config option to control whether DTD's are cached, but its more a global > option than a pipeline-specific option... Is looking for it under > domify/config the right thing to do, or is there another preferred method? > > 2) It stores the parsed XML in the document as an attribute, which when > trying to journal the document caused me to hit java bug 4152790 - > StackOverFlowError serializing / deserializing a large graph of objects. I > got to thinking, even if I could get past the java bug, does it make sense > to journal the DOM representation? So I have implemented the DOM > representation cache as a WeakHashMap in DomifyPipelineStage instead, and > it seems to work. Any objections to commiting this? > > -Jonathan |