[Babeldoc-devel] Re: Patch for GenericSqlJourna

[Ken G. <kg...@sp...>]

I made this change locally to be able to view forked tickets in the web 
console.  I made a comment about it but there was no response.  I have 
seen no side effects and can only expect this change to be a good thing.


Ken

Stefan Krieger wrote:
> Folks,
> 
> I needed to change "forkTicket" in sql.journal.GenericSqlJournal to make
> forking actually working.
> Without this change an unusable text is stored in the OTHER_DATA column.
> Does anyone expect any sideeffects ?
> 
> Regards,
> Stefan
> 
>   public synchronized IJournalTicket forkTicket(IJournalTicket parentTicket)
>       throws JournalException {
>     try {
>       //getLog().debug("[GenericSqlJournal.forkTicket] called");
>       Connection con = (Connection) resource.checkOut();
>       long nextVal = TableKeyHelper.getNextId(con, "LOG").longValue();
>       resource.checkIn(con);
> 
>       IJournalTicket ticket = new JournalTicket(nextVal);
> 
>       // Log the operation
>       // PATCH: use getId() instead of toString() to track the parentId in
> the Database
>       log(ticket, JournalOperation.forkTicket, parentTicket.getId(), null,
> null);
> 	//log(ticket, JournalOperation.forkTicket, parentTicket.toString, null,
> null);
> 
>       return ticket;
>     } catch (Exception iox) {
>       throw new JournalException("[GenericSqlJournal.forkTicket]", iox);
>     }
>   }