|
From: Ken G. <kg...@sp...> - 2003-06-17 00:21:07
|
Done. I just realized that I never checked in my PostgreSQL scripts and PostgreSqlJournal implementation. I'll do that soon. In the next few days, I will be working on ConfigService to try out commons-discovery. It might cause some changes (instead of -Dbabel.config=FooConfig, you may need to do -Dcom.babeldoc.core.config.IConfigService=FooConfig. If that is not acceptable, I can code it to check babel.config first. In any case, I need to change the use of Class.forName() to Thread.currentThread().getContextClassLoader() for use in J2EE environments. Bruce McDonald wrote: > Thats a good point. On the face of it, it looks like the addToContext method > should be synchronized. Can you make the change. > > regards, > Bruce. > > On Monday 16 June 2003 06:38 pm, Ken Geis wrote: > >>I was looking at the code to com.babeldoc.core.VariableProcessor. I >>have a little problem with it. >> >>Why is getContext() synchronized? No other method in VariableProcessor >>is synchronized. This means that you are trying to avoid having two >>threads attain a reference to the context at the same time. It makes no >>assurance on synchronizing accesses to the methods on the context >>object. I could understand synchronizing addToContext(name, object). |