|
From: Bruce M. <br...@mc...> - 2003-04-08 14:17:48
|
Hans, This is a trick question. The first thing to do is to make you a developer. I am on this now. You will have to get your SSH public key uploaded to sourceforge. Now as to the question of changing the SOAP library - heres my thinking: (This email has been written in stages) This sounds good. Thanks for you efforts here. Please make the change but bear in mind that if you change the "SOAP library" from apache's to sun's then you will have to touch other code too. You will have to be sure that you can do it all before you start a wholesale rewrite. regards, Bruce. On Tuesday 08 April 2003 08:50 am, Hans Benedict wrote: > On Mon, 7 Apr 2003, Bruce McDonald wrote: > > Unfortunately this pipelinestage has not recieved all the attention that > > other stages have. I would welcome suggestions as to how to address > > these kinds of issues. > > Bruce, > > I took some time reading the sources of Apache SOAP. The http status is > read somewhere down in org.apache.soap.util.net.HTTPUtils and then > ignored. So it is not accessible from the point where you call > the send method of org.apache.soap.messaging.Message. And even the parsing > of the (html) error message of the server does not lead to an > SOAPException. > > The only way I see to fix this, is to use another SOAP API. My suggestion > is to switch to Sun's JAXM/SAAJ API, which throws a SOAPException when > encountering an 404 error. The rewrite of the SOAPWriterPipelineStage > should not be to difficult, but I have not yet looked at the two other > classes. Is any of the other modules using the SOAP API? > > Concerning real SOAP faults, it seems that the client, i.e. the > pipelinestage, has to check the SOAP response for them, and then throw an > Exception by itself. > > If you agree, I could do the rewrite as well as the additional fault > handling. But probably you don't want to have too many changes before the > 1.0 release... Maybe, we should only add the fault handling and keep the > rewrite for later? > > Regards, > Hans |