From: Marcus D. H. <mar...@ki...> - 2012-01-23 14:30:21
|
On Sun, Jan 22, 2012 at 2:54 PM, Geoff Hutchison <ge...@ge...> wrote: >> submit topics, and that will create an appropriate merge commit, which >> will be pushed to replicated locations (normally within minutes). > > So does that mean that we should review a whole topic branch and then submit the tip of the branch? > > I'm looking at things like: > http://review.source.kitware.com/#/c/3549/ That is an individual change, and until we work through all of these they should be submitted when they are approved (as I did) and they will be merged correctly. I was referring to things like, http://review.source.kitware.com/#/t/9/ This is a topic which has one commit, reviewing the individual commits and then submitting the entire topic from this page once the topic is ready to be merged. Open topics can be found by going to All -> Topics -> Open on the top navigation bar. A topic has a list of all commits that are part of the topic, and you can extend topics (add new commits) or drop commits from topics (causing individual changes to be marked as abandoned). The testing scripts I have will test the topic tips, and I will be bringing dashboard resources online to automate this testing of the topic tips soon with Kyle and Dave Cole's help. Let me know if anything is unclear, I will finish up the wiki pages explaining how all of this works and provide pointers there too. Marcus |