From: Marcus D. H. <ma...@cr...> - 2008-04-27 19:44:45
|
> On Friday 25 April 2008 23:32:59 Benoît Jacob wrote: > > Hi List, > > > > Albert Astals Cid said on #kalzium that he saw misuses of Qt's "foreach" > > in libavogadro. Understandably, he's not eager to fix them in kalzium's > > snapshot of libavogadro, but he suggested that I pointed anybody > > interested to his blog post on this subject: > > > > http://tsdgeos.blogspot.com/2008/04/qforeach-is-your-friend.html > > > > Hope this interests anybody, > > > > Benoit OK - I made the changes to the places he pointed out. I had a quick scan around and couldn't spot similar stuff but we use foreach loops in a lot of places. I will fix these as I see them. I am always in favour of making Avogadro more efficient where we can :-) Thanks for pointing it out - I had read the blog post but hadn't yet looks through our codebase for it. |