From: Marian B. <mar...@ov...> - 2018-07-10 07:51:04
|
Hi, the attached patch fixes an incorrect return statement: Apparently old GCC versions implicitly casted "false" to "NULL", which no longer is the case. So the "return false;" statement in jtagrw.cc:134 in function uchar *jtag1::jtagRead(unsigned long addr, unsigned int numBytes) should be replaced by "return NULL;" Also, there is a lot of inconsistent use of tabs and spaces for indent. Maybe running astyle, uncrustify, or whatever of the code would be a good idea? ;-) Kind regards, Marian ------------------------------------------------------------- M.Sc. Marian Buschsieweke Dept. Communication and Networked Systems (ComSys) Institute for Intelligent Cooperating Systems (IKS) Otto-von-Guericke-University of Magdeburg Universitätsplatz 2, Building 29, Room 314 39106 Magdeburg Germany http://www.comsys.ovgu.de/Team/Marian+Buschsieweke.html Tel.: +49 - 391 - 67 - 52673 Fax: +49 - 391 - 67 - 41161 |