Menu ▾ ▴

#2901 Recent change in JythonUtil breaks addPointDigitizer script

nextrelease
open
nobody
None
5
3 hours ago
4 hours ago
No

The script https://research-git.uiowa.edu/abbith/juno/-/blob/main/team/digitizer/addPointDigitizer.jy is broken with the latest production Autoplot, v2026a_8. (Darrelle discovered this.) This is because new code in the simplifyScriptToGetParams refactoring results in an invalid script. It has to do with:

if ( reduc=='' ): reduc= None
else: reduc= dataset('0.5s')

and the "else:" is left in the script. I figured out that new code in visitName(Name node) is the change, and I'll revert that and make a release.

Discussion

  • Jeremy Faden

    Jeremy Faden - 4 hours ago

    I'm going to make a small code that demos the bug, then change the script on research-git and then fix the problem in the morning.

     
  • Jeremy Faden

    Jeremy Faden - 3 hours ago

    Here is a reduced version of the script which shows the bug:

    reduc= getParam( 'reduce', '1s', 'reduce to resolution', ['','1s'] )
    
    if ( reduc=='' ): reduc= None
    else: reduc= dataset('0.5s')
    
    newVersion= True # getParam( 'newVersion', True, 'Run with new version (requires 20200605a or v2020a_7)', [ True, False ] )
    
    allowReload = getParam( 'allowReload', True, 'listen for timerange changes and allow navigation without reload', [ True, False ] )