#2845 three completions wants

[Jeremy Faden]

There's another ticket of wants for completions, but I should keep these small and closable:

1. code fragment for "assert isinstance( p, Plot )"
2. p,pe= plot(...) will assign the type Plot to p and PlotElement to pe
3. p.getController().<t> results in "name error: p"</t>

[Jeremy Faden]

item 4. from org.das2.graph import Das<t> doesn't show DasAxis as a completion.</t>

[Jeremy Faden]

See https://github.com/autoplot/dev/blob/master/bugs/ghdas2/0179/demoUnitsHandling.jy

[Jeremy Faden]

(1) is added. (2) appears to be handled already.

[Jeremy Faden]

(3) is kludged in

[Jeremy Faden]

I'm not sure what's going on with (4). I looked at the code which looks for the symbols and the code looks clean. Actually there are two relevant paths:

from org.das2.graph import Das<T>
org.das2.graph import Das<T>

The first path works properly and sees the symbol, but the second doesn't.

[Jeremy Faden]

Okay, the problem is with Jython, where it doesn't know about the symbol DasAxis unless someone has told it. If I first import the symbol then run the code:

targetComponents = 'org.das2.graph'.split('.')
base = targetComponents[0]
baseModule = __import__(base, globals(), locals())
module = baseModule    
for component in targetComponents[1:]:
    module = getattr(module, component)
list = dir(module)

(which is what is used for completions) it does see the symbol. So I think the fix is to also look at the giant list of imports to see if there are other known imports.

[Jeremy Faden]

This is fixed by importing the known names before querying the module.