Menu

#2376 Jython setItem with index lists didn't check units

nextrelease
open-fixed
nobody
None
5
2021-09-26
2021-08-04
No

Ivar noticed that setItem on PyQDataset didn't handle the units property when index lists were used, failing to check to see if a converter is needed.

I should review all setitem branches for this. It seems likely none of the branches do.

Discussion

  • Jeremy Faden

    Jeremy Faden - 2021-08-04

    Also a review of mutability is needed. See https://github.com/autoplot/dev/bugs/sf/2376/demoBugBundle2.jy
    which shows how when dd has been marked immutable, it can still be modified by way of its mutable bundled dataset.

     
  • Jeremy Faden

    Jeremy Faden - 2021-08-04

    I've made the DataSetIterator interface have getRank0Value and putRank0Value, which ensure that the units are handled properly (and efficiently at some point).

     
  • Jeremy Faden

    Jeremy Faden - 2021-09-26

    See https://sourceforge.net/p/autoplot/bugs/2391/ which shows where the change made here slowed things down unacceptably.

     
  • Jeremy Faden

    Jeremy Faden - 2021-09-26
    • status: open --> open-fixed
     
MongoDB Logo MongoDB