#1636 jython error squiggle location incorrect / getParam simplification

[Jeremy Faden]

The error squiggle location displayed for jydsCommentBug.jyds is incorrect, because it's based on the location of the simplified script used to get parameters.

See "/home/jbf/ct/hudson/script/test038/jydsCommentBug.jyds" on nudnik.physics.uiowa.edu.

1. enter "/home/jbf/ct/hudson/script/test038/jydsCommentBug.jyds" in the address bar.
2. this rejects, because of an error in parsing.
3. note line 48 is highlited.
4. the "problems indicated" droplist shows line 48.

line 48 is in the simplified script...

[Jeremy Faden]

Ivar had another case where the simplified version has a bug.

See sftp://nudnik.physics.uiowa.edu/home/jbf/project/autoplot/bugs/1636/energy-deposition3.jyds

[Jeremy Faden]

Here's a script that shows what Autoplot is running to get the parameters GUI:

from org.virbo.jythonsupport import JythonUtil
from java.io import FileReader
d= 'file:/home/jbf/project/autoplot/bugs/1636/energy-deposition3.jyds'
resourceURI= getParam( 'resourceURI', d, 'example file to load' )
ss= downloadResourceAsTempFile(URL(resourceURI),monitor)
script= JythonUtil.readScript( FileReader(ss) );
print JythonUtil.simplifyScriptToGetParams( script, False )

[Jeremy Faden]

I thought it might be a good idea to insert blank lines where we are skipping, so it's easier to compare with the original script.

[Jeremy Faden]

I took out the blank lines addition, which made it harder to figure out what was going on. Actually, comments and imports should be removed, if we want to make it easier to debug. The script that saves the simplified version is very useful, and now saves the new version.

[Jeremy Faden]

I've been looking at this today, and off and on for the past month on a ticket I can't find now.

[Jeremy Faden]

check on print, I was seeing an issue with Sadie

[Jeremy Faden]

Sadie had a script which ended in ''', which caused a strange bug when it was scraped for getParam calls. See /mynet/spot8/home/jbf/project/juno/u/sadie/20210205/Make_new_files.jy and ~/ct/hudson/script/test038/trailingStringBug.jy