Menu

#178 configure issues with 5.18.10

autogen
closed
None
1
2020-09-14
2016-07-21
No

The following patch is useful to:
1. allow a packaging manager override the POSIX_SHELL at configure time
2. fix ./configure: line 17794: test: too many arguments

--- configure.orig  2016-05-24 18:36:00.000000000 +0000
+++ configure
@@ -15509,6 +15509,7 @@ $as_echo "$ac_cv_path_SED" >&6; }

   while :
   do
+  test -x "$POSIX_SHELL" && break
       POSIX_SHELL=`which bash`
       test -x "$POSIX_SHELL" && break
       POSIX_SHELL=`which dash`
@@ -17790,7 +17791,8 @@ else
  INCLIST="${INCLIST} -I\${top_builddir}/autoopts -I\${top_srcdir}/autoopts"
 fi

-test ${GUILE_VERSION} -ge 108000 \
+GUILE_VERSION=${ag_gv}
+test "${GUILE_VERSION}" -ge 108000 \
   -a "X${WERROR}" = Xyes \
   -a "X${GCC}" = Xyes && \
     CFLAGS=`echo $CFLAGS -Wall -Werror -Wcast-align -Wmissing-prototypes \

as to POSIX_SHELL, there seems to be other places than configure using similar logic
(autoopts/mk-tpl-config.sh) that don't take into consideration that configure has done these tests
and has set POSIX_SHELL already.

Discussion

  • Bruce Korb

    Bruce Korb - 2016-07-21
    • status: open --> pending
    • assigned_to: Bruce Korb
     
  • Bruce Korb

    Bruce Korb - 2016-07-21

    The current version is 5.18.11:

    $ fgrep GUILE_VERSION configure

    define GUILE_VERSION ${ag_gv}

    $ autogen --version
    autogen (GNU AutoGen) 5.18.11

    I have added the test for presetting POSIX_SHELL, but the second patch already reads:

    test ${ag_gv} -ge 108000 \ -a "X${WERROR}" = Xyes \ -a "X${GCC}" = Xyes && \ CFLAGS=`echo $CFLAGS -Wall -Werror -Wcast-align -Wmissing-prototypes \ -Wpointer-arith -Wshadow -Wstrict-prototypes -Wwrite-strings \ -Wno-format-contains-nul -fno-strict-aliasing -Wstrict-aliasing=3 \ -Wextra -Wno-cast-qual

     
  • Bruce Korb

    Bruce Korb - 2016-07-21

    Ticket moved from /p/autogen/patches/6/

     
  • Bruce Korb

    Bruce Korb - 2020-09-14
    • status: pending --> closed
     
  • Bruce Korb

    Bruce Korb - 2020-09-14

    fixed

     

Log in to post a comment.