Re: [Audit-test-developer] [PATCH 16/20] utils/netfilter: remove config-server

[Linda K. <lin...@hp...>]

On 05/02/13 13:25, Jiri Jaburek wrote:
> On 04/22/2013 10:26 PM, Linda Knippers wrote:
>> I never used this script as for me it was easier to just edit the
>> template and set the network up myself.
>>
>> Does the script not generate the right variables and configuration
>> if someone does use it?
>>
>> If we don't think it add value and just makes for yet another thing
>> to maintain, I'm ok with removing it.
>>
> 
> I didn't really test the script, but I don't think it works during
> normal runtime, ie. after OS installation. The interactive part,
> that is.
> 
> Functions like
> 
> echo_user () {
>         echo >/dev/tty "$@"
> }
> 
> are common for kickstart files, so I'm guessing this script's
> interactive usage was during system installation (?).
> 
> If one used the bundled profile.sample and modified it, the script just
> copied the variables, creating the same thing in another file.
> 
> Furthermore, it uses ifconfig and route, neither of which is available
> on RHEL7 by default, so it would need rewrite anyway.
> 
> That being said, I fail to see any advantage gained by using this
> script, even if it works. It may configure the interfaces correctly
> (using ifconfig and route), but it doesn't do it persistently.
> 
> Also, it needs to have $BRIDGE_FILTER already created as a bridge
> by the user, so it's not usable "out of the box".
> 
> Even if we rewrote it and made it pretty again, it wouldn't really save
> that much time. Instead of configuring the ifcfg files on both TOE
> and NS, one would need to export a lot more variables on both TOE and NS
> and run the script after each reboot from a TTY console. Likely
> restarting various services afterwards.
> 
> Would it be better? I don't think so.

I'm with you.  If it's just more to maintain and it's not really
useful, let's remove it.

-- ljk

> 
> Jiri
>